Bug 156015 - Mark unimplemented arguments of BASIC Shell function as such
Summary: Mark unimplemented arguments of BASIC Shell function as such
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Olivier Hallot
URL:
Whiteboard: target:24.2.0 target:7.6.0.0.beta2
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-22 06:16 UTC by Mike Kaganski
Modified: 2023-07-19 17:37 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2023-06-22 06:16:29 UTC
Shell function documentation [1] lists 7 possible values of Windowstyle argument (0, 1, 2, 3, 4, 6, 10). It follows MS documentation [2], with an addition of 10. But the implementation [3] only knows three: 2, 3, and 10.

All the values not implemented currently need to be marked as such in the documentation.

[1] https://help.libreoffice.org/7.5/en-US/text/sbasic/shared/03130500.html?DbPAR=BASIC
[2] https://learn.microsoft.com/en-us/office/vba/language/reference/user-interface-help/shell-function
[3] https://opengrok.libreoffice.org/xref/core/basic/source/runtime/methods.cxx?r=e7dbef92&mo=103233&fi=3480#3470
Comment 1 Mike Kaganski 2023-06-22 08:02:18 UTC
Additionally:

1. The window style flags are only functional on Windows; on other platforms, they are totally ignored [1].
2. On Windows, 3 and 10 are equivalent [2].

[1] https://opengrok.libreoffice.org/xref/core/sal/osl/unx/process.cxx?r=4f743219#541
[2] https://opengrok.libreoffice.org/xref/core/sal/osl/w32/procimpl.cxx?r=a0c08ce6#498
Comment 2 Commit Notification 2023-06-22 19:28:30 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/47a2e63384c754cf2c8766bc1d03b9a1d009c498

tdf#156015 Mark unimplemented args of BASIC Shell
Comment 3 Commit Notification 2023-06-24 11:13:13 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/help/commit/472dfac74c2d0cb8dabb9c9bd377c86c472de6f1

tdf#156015 Mark unimplemented args of BASIC Shell