Bug 156063 - Wrong text alignment with strikethrough within vertical writing (again)
Summary: Wrong text alignment with strikethrough within vertical writing (again)
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.5.4.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks: Vertical-Text
  Show dependency tree / graph
 
Reported: 2023-06-26 16:16 UTC by Volga
Modified: 2023-07-03 09:14 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Test file (16.78 KB, application/vnd.oasis.opendocument.text)
2023-06-26 16:18 UTC, Volga 		Details
Screenshot (113.12 KB, image/png)
2023-06-26 16:26 UTC, Volga 		Details
Test font (4.50 MB, application/x-7z-compressed)
2023-06-26 16:32 UTC, Volga 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Volga 2023-06-26 16:16:52 UTC 
Description:
In LibreOffice 7.5, the text alignment issue with strikethrough is happened again. In this case both Tangut and Nuosu scripts get affected again.

Steps to Reproduce:
1. Insert text boxes with vertical text layout set
2. Insert Nuosu and Tangut sample texts respectively
3. See the error

Actual Results:
All these characters shift to right relative to the strikethrough.

Expected Results:
In vertical text layout, all upright glyphs should be proper aligned as the following sample:
https://drafts.csswg.org/css-writing-modes-4/#vertical-metrics


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.5.4.2 (X86_64) / LibreOffice Community
Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: zh-CN (zh_CN); UI: zh-CN
Calc: threaded

Test font:
Nuosu SIL https://software.sil.org/nuosu/
Tangut N4694 http://www.ccamc.co/fonts_tangut.php
Comment 1 Volga 2023-06-26 16:18:51 UTC 
Created attachment 188096 [details]
Test file
Comment 2 Volga 2023-06-26 16:26:04 UTC 
Created attachment 188097 [details]
Screenshot
Comment 3 Volga 2023-06-26 16:32:08 UTC 
Created attachment 188098 [details]
Test font

You can get all test fonts here.
Comment 4 ⁨خالد حسني⁩ 2023-06-26 18:36:53 UTC 
Is this a regression? If so when was it working correctly?
Comment 5 Volga 2023-06-28 01:00:43 UTC 
I saw it have been fixed in 7.2.
Comment 6 ⁨خالد حسني⁩ 2023-07-03 09:14:38 UTC 
Bibisected to:

commit ba03e033d1be4bc49f2a8d6afbeecd381507b242
Author: Khaled Hosny <khaled@aliftype.com>
Date:   Fri Sep 30 18:36:59 2022 +0200

    vcl: Use font’s underline/strike position and size


These are font bugs. Nuosu SIL has OS/2.yStrikeoutPosition = 512 and Tangut N4694 has it = 249 and both values are too low. This also affects horizontal text.

I suggest you report this issue to upstream font developers. You can also restore the old behavior by adding the font family names to FontsDontUseUnderlineMetrics from expert configuration.