Bug 156067 - special character pop-up - delete recent
Summary: special character pop-up - delete recent
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.3 release
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:24.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-26 21:21 UTC by raal
Modified: 2023-07-02 21:25 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description raal 2023-06-26 21:21:42 UTC
Description:
.

Steps to Reproduce:
1. Open Writer
2. button Special character
3. Right click icon in recent section
4. select Remove

Actual Results:
nothing happens

Expected Results:
character should be deleted


Reproducible: Always


User Profile Reset: No

Additional Info:
Repro on Windows, Linux, 7.6 dev
Comment 1 raal 2023-06-26 21:27:21 UTC
@Caolán, bisected with linux-64-6.5. Before suspiciuos commit right click menu wasn't available. After the commit menu on right click appears, but clicking Remove do nothing.
 8091bc8471a23a54ddad81eb85f06a643aa6f54b is the first bad commit
    source 94c1f5cfb96a826220b64608cf0ada76d3bdde31

86664: rework SfxCharmapCtrl to be a PopupWindowController | https://gerrit.libreoffice.org/c/core/+/86664

Please can you take a look? Thank you.

(https://ask.libreoffice.org/t/unable-to-delete-unwanted-char-icon/92906)
Comment 2 Kamil Landa 2023-06-27 07:26:44 UTC
Confirmed, menu Remove or Clear All do nothing.  

Version: 7.5.4.2 (X86_64) / LibreOffice Community
Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6
CPU threads: 8; OS: Windows 10.0 Build 17763; UI render: Skia/Raster; VCL: win
Locale: cs-CZ (cs_CZ); UI: cs-CZ
Calc: CL threaded Jumbo

Version: 7.6.0.0.beta1 (X86_64) / LibreOffice Community
Build ID: be55b15d98c5f059483845a183fcb5ea8023d27c
CPU threads: 8; OS: Windows 10.0 Build 17763; UI render: Skia/Raster; VCL: win
Locale: cs-CZ (cs_CZ); UI: cs-CZ
Calc: CL threaded Jumbo
Comment 3 Caolán McNamara 2023-06-27 11:53:20 UTC
I wonder if the control just got dismissed on a right click before because there isn't anything special in that commit to enable the menus. Either way I think the underlying problem is there since the original implementation of the popup
Comment 4 Commit Notification 2023-06-28 07:42:15 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c706fde1c4ecc6974bcf32ce33aacf3093355ae1

Resolves: tdf#156067 merge special char dialog/popup logic

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Kamil Landa 2023-07-02 21:25:58 UTC
Verified, fixed in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c7d202a61f9ce81b76b29e61252c23aa66daff07
CPU threads: 8; OS: Windows 10.0 Build 17763; UI render: Skia/Raster; VCL: win
Locale: cs-CZ (cs_CZ); UI: en-US
Calc: CL threaded Jumbo