Bug 156101 - Thesaurus supposedly enabled, but grayed out in UI
Summary: Thesaurus supposedly enabled, but grayed out in UI
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0 target:7.6.0.0.beta2
Keywords:
Depends on:
Blocks: Thesaurus
  Show dependency treegraph
 
Reported: 2023-06-30 09:45 UTC by Eyal Rozenberg
Modified: 2023-07-07 14:20 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2023-06-30 09:45:05 UTC
I'm using this build:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5cd9de202765e243e41416802f3e4486b8a96f16
CPU threads: 4; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: he-IL (en_IL); UI: en-US

with both RTL-CTL and Asian languages enabled.

I would like to enable the Thesaurus. First I should say, that nothing in the UI (outside the preferancles) seems to hint at there even being a thesaurus. Additionally, when I visit Tools | Options | Languages | Writing Aids - the thesaurus for English seems to be enabled. But - it's not working.

Do I need to do something else to make it work? If so, that's confusing and difficult. If not, then it's a bug.
Comment 1 m_a_riosv 2023-06-30 11:46:47 UTC
Could you ask first in the forum?
Comment 2 BogdanB 2023-06-30 18:42:36 UTC
I have Thesaurus in Tools - Thesaurus... (is the third menu).

If I write a word, in the window that opened, I get many expressions that use that word.
Comment 3 Eyal Rozenberg 2023-06-30 20:17:26 UTC
(In reply to BogdanB from comment #2)
> I have Thesaurus in Tools - Thesaurus... (is the third menu).

Ok, so - I do have it, but grayed out. Rephrased title. It should be enabled though.
Comment 4 Stéphane Guillou (stragu) 2023-06-30 21:34:13 UTC
(In reply to Eyal Rozenberg from comment #3)
> Ok, so - I do have it, but grayed out. Rephrased title. It should be enabled
> though.

What language is the text where you cursor is? If you don't have a Thesaurus installed for that language, the UI is greyed out.

https://help.libreoffice.org/latest/en-US/text/swriter/guide/using_thesaurus.html
Comment 5 Eyal Rozenberg 2023-06-30 21:44:29 UTC
(In reply to Stéphane Guillou (stragu) from comment #4)
> What language is the text where you cursor is? If you don't have a Thesaurus
> installed for that language, the UI is greyed out.

English (Israel).

ah, so, the funny things is, in the list of language variants in the Writing Aides "Available language modules" edit dialog - we don't even get English (Israel) as an option! ... and there isn't an English-fallback option. Maybe that's the problem?
Comment 6 QA Administrators 2023-07-01 03:13:25 UTC Comment hidden (obsolete)
Comment 7 Stéphane Guillou (stragu) 2023-07-01 14:20:56 UTC
Maybe this is just a matter of listing en-IL somewhere so the Hunspell MyThes also works for that language?

Caolán, László, any idea?
Comment 8 Caolán McNamara 2023-07-01 20:53:08 UTC
yeah, likely this new en-IL need to be added to 
https://cgit.freedesktop.org/libreoffice/dictionaries/tree/en/dictionaries.xcu
in the various sections.

We have only one thesarus so the ThesDic_en-US section is simple.

For the others the spelling variant GB vs US matters. From:
https://www.guyrutenberg.com/2016/04/16/en_il-english-locale-for-israel/
I imagine en-IL should slot into HyphDic_en-US and HunSpellDic_en-US
Comment 9 Caolán McNamara 2023-07-01 20:56:57 UTC
lets try https://gerrit.libreoffice.org/c/dictionaries/+/153852
Comment 10 Eyal Rozenberg 2023-07-01 21:19:43 UTC
(In reply to Caolán McNamara from comment #8)
> yeah, likely this new en-IL need to be added to 
> https://cgit.freedesktop.org/libreoffice/dictionaries/tree/en/dictionaries.
> xcu
> in the various sections.
> 
> We have only one thesarus so the ThesDic_en-US section is simple.
> 
> For the others the spelling variant GB vs US matters. From:
> https://www.guyrutenberg.com/2016/04/16/en_il-english-locale-for-israel/
> I imagine en-IL should slot into HyphDic_en-US and HunSpellDic_en-US

But why is there no per-language fallback, for when the locale is missing? Tomorrow someone will complain about en-JO or en-PA or en-EG etc.

Of course, you could ask me to open a separate bug about that.
Comment 11 Commit Notification 2023-07-02 13:51:59 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/dictionaries/commit/3fdd5e2b1d652e4ee7212c934d916971fc74a203

tdf#156101 add en-IL alongside the other English locales
Comment 12 Caolán McNamara 2023-07-02 14:05:20 UTC
done in trunk, untested however. backport to 7-5 in gerrit as I see en_IL in 7.5
Comment 13 Commit Notification 2023-07-03 12:03:22 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/dictionaries/commit/b1beb866b76156410f80a79b4d1b9ed4d2fa528c

tdf#156101 add en-IL alongside the other English locales
Comment 14 Stéphane Guillou (stragu) 2023-07-05 15:40:48 UTC
Verified as fixed in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d74344f6cae0cf1c12f08249c8f49be1374fb98f
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thanks Caolán!

(In reply to Eyal Rozenberg from comment #10)
> Of course, you could ask me to open a separate bug about that.

For the fallback issue, looking at https://cgit.freedesktop.org/libreoffice/dictionaries/tree/en/dictionaries.xcu and how variants are specified in the same way for hyphenation, thesaurus, and spelling, I think it is already covered by bug 83561. Once the fallback mechanism is implemented, we can see with each native language community which fallback works for them - if any.