Bug 156308 - /org.openoffice.Office.Recovery/AutoSave vs /org.openoffice.Office.Common/Save/Document
Summary: /org.openoffice.Office.Recovery/AutoSave vs /org.openoffice.Office.Common/Sav...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Mike Kaganski
URL:
Whiteboard: target:24.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-16 09:56 UTC by Mike Kaganski
Modified: 2023-07-20 11:22 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2023-07-16 09:56:33 UTC
There are these configuration nodes:

/org.openoffice.Office.Recovery/AutoSave
  -> Enabled
  -> TimeIntervall

/org.openoffice.Office.Common/Save/Document
  ->AutoSave
  ->AutoSaveTimeIntervall

It *seems* that the former is for the recovery information, and the latter is for documents autosave (that recently was re-enabled). However, the Options->Load/Save->General only has one interval entry, and it seems to be related to recovery information; yet, it stores the "/org.openoffice.Office.Common/Save/Document/AutoSaveTimeIntervall". Then, the code in framework/source/services/autorecovery.cxx either *reads* "/org.openoffice.Office.Common/Save/Document/AutoSaveTimeIntervall", *or* listens to changes in "/org.openoffice.Office.Recovery", and only *if* there were changes in the latter, it would consider the new value for its "AutoSave/TimeIntervall".

What is the confusion around these configuration values? What should be changed?
Comment 1 Mike Kaganski 2023-07-16 14:43:35 UTC
 d0f9685d2cfc3927add412b276c804dcc20cb6a5 (2004-11-26)
  made SvtSaveOptions use org.openoffice.Office.Recovery/AutoSave, *in addition* to org.openoffice.Office.Common/Save/Document/*, as "forward AutoSave/AutoSaveTime to new config location" part of i#27726; at this point, org.openoffice.Office.Recovery/AutoSave* took precedence (hey were read last).
 8e6031e126782ced6d7527b19cf817395e9b63e4 (2004-11-26)
  implemented autorecovery.cxx, already reading org.openoffice.Office.Recovery/AutoSave/*
 d5b9283985633fdb423269cab961bba2acc3539e (2021-07-25)
  made SvxSaveTabPage and SfxApplication::SetOptions_Impl use officecfg::Office::Common::Save::Document::* instead of SvtSaveOptions (but SvtSaveOptions used Document/AutoSaveTimeIntervall already for reading data).
 134f40136a9bea265d8f2fedfdb41a1e65d81b49 (2021-07-25)
  dropped SvtSaveOptions_Impl::ImplCommit, and its saving of officecfg::Office::Recovery::AutoSave::* (which likely detached officecfg::Office::Recovery::AutoSave from officecfg::Office::Common::Save::Document).
 aeb8a0076cd5ec2836b3dfc1adffcced432f995f (2022-05-23)
  made AutoRecovery::implts_readAutoSaveConfig read officecfg::Office::Common::Save::Document::* instead of proper officecfg::Office::Recovery::AutoSave::*.

I guess, since from 2004 till 2021, autorecovery used only org.openoffice.Office.Recovery/AutoSave/*, we should restore its use, and deprecate the other obsolete values.
Comment 2 Mike Kaganski 2023-07-16 15:46:47 UTC
https://gerrit.libreoffice.org/c/core/+/154500
Comment 3 Commit Notification 2023-07-17 19:14:49 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3c41b32562d5ccdd306000484c5b16245b2b4a4f

tdf#156308: Restore use of /org.openoffice.Office.Recovery/AutoSave

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2023-07-20 01:26:59 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/896f19764abf9301169bf9631877bdae075edde4

tdf#156308 autosave: re-listening to config, no restart requests

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.