Bug 156501 - Calc View Headers setting is not saved to file
Summary: Calc View Headers setting is not saved to file
Status: RESOLVED INVALID
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.6.0.1 rc
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, dataLoss, regression
Depends on:
Blocks: Calc-UX
  Show dependency treegraph
 
Reported: 2023-07-27 22:18 UTC by ady
Modified: 2024-06-05 13:09 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ady 2023-07-27 22:18:17 UTC
The setting of:
 Menu View > View Headers 
is not being saved to the file (at all, whether with or without other changes).

The behavior/problem is slightly different in versions prior to 7.6. This is seen in LO 7.6.0.1, but _not_ in 7.5.3.2. It might have started at some point in the 7.6. development cycle.

STR:
1. New Calc.
2. A1: 1
3. Menu View > View Headings > set it to OFF (if needed).
4. A2: 2
5. Save the file, close and reload it.

The row/column Headers are displayed, as if the setting was not saved to the file.

Additional test:

6. Close LO 7.6.
7. Open the file in LO 7.5.
8. Menu View > View Headings > set it to OFF (if needed).
9. _Force_ saving the file with [CTRL]+[S]; close LO 7.5.
10. Open the file in LO 7.6 > row/column Headers are not displayed, as expected.
10.1. In LO 7.6, change the status of the View Headers setting to ON (if needed).
11. _Force_ saving the file with [CTRL]+[S]; close LO 7.6.
12. Open the file in LO 7.5.
13. Menu View > View Headings > set it to ON (if needed).
14. _Force_ saving the file with [CTRL]+[S]; close LO 7.5.
15. Open the file in LO 7.6 > row/column Headers are displayed, as expected.

IOW, LO 7.5 can save the status of the View Headers setting, and LO 7.6 can read that status correctly (when saved in LO 7.5); but when changing the status in LO 7.6, it is not saved to the file.

This bug report is based on testing bug 153295, which has another problem regarding saving the status of the View Headers setting in versions prior to 7.6. IOW, the behavior is even worse since LO 7.6, but the reasons might be different, so these are 2 separate reports.
Comment 1 m_a_riosv 2023-07-27 23:37:24 UTC Comment hidden (obsolete)
Comment 2 ady 2023-07-27 23:58:41 UTC
(In reply to m.a.riosv from comment #1)
> Works on
> Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
> Build ID: cf8f7b91f41821b79495c0388359c4cb1156ea67
> CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL:
> win
> Locale: es-ES (es_ES); UI: en-US Calc: CL threaded

@Miguel, for me, it still fails in (same build as yours, from today 2023-07-27):

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: cf8f7b91f41821b79495c0388359c4cb1156ea67
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (es_AR); UI: en-US
Calc: CL threaded

> 
> Regression
> Version: 7.6.0.1 (X86_64) / LibreOffice Community
> Build ID: 776eaf34564cbf3f034a0ba1fd1d5c32ff9ccf1c
> CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL:
> win
> Locale: es-ES (es_ES); UI: en-US Calc: CL threaded
> 
> Looks the issue it's at saving, opening with 7.6 a file saved with 7.5 open
> fine.
Correct; that's why I added the "Additional test" in comment 0.
Comment 3 ady 2023-07-28 05:31:25 UTC Comment hidden (off-topic)
Comment 4 m_a_riosv 2023-07-28 13:15:27 UTC
You are also fails on
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 42f0422d19c4d0a2fb09654fb6d1d92e50f6dd5c
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: default; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded
Sure I was opening a file created with 7.5
Comment 5 Colin 2023-07-30 06:18:35 UTC Comment hidden (obsolete)
Comment 6 ady 2023-07-30 17:17:11 UTC Comment hidden (obsolete)
Comment 7 raal 2023-08-08 16:17:32 UTC
 d60282e0e4af27877447c9da359c6ec75e355a99 is the first bad commit
commit d60282e0e4af27877447c9da359c6ec75e355a99
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Wed Mar 8 12:08:52 2023 +0100

    source 3fcf9f864f9d12fdb0ade4741127c81cec74378a
Comment 8 raal 2023-08-08 16:20:55 UTC
This seems to have begun at the below commit in bibisect repository/OS linux-64-7.6.
Adding Cc: to Grigory Mozhaev ; Could you possibly take a look at this one?
Thanks

147914: tdf#97551 Added marker and hint for formula to Calc | https://gerrit.libreoffice.org/c/core/+/147914
Comment 9 ady 2023-08-09 03:19:57 UTC
(In reply to raal from comment #8)
> 147914: tdf#97551 Added marker and hint for formula to Calc |
> https://gerrit.libreoffice.org/c/core/+/147914

Considering that tdf#97551 is related to Calc's UI (and UX), and that Heiko and Eike (among others) participated in that gerrit issue, I am CC'ing both of them to this bug 156501. That is, even though this bug 156501 is about SAVING (and a behavior that is worse than it was before LO 7.6).
Comment 10 Heiko Tietze 2023-08-15 10:23:56 UTC
Why do you expert View > View Headers (uno:ViewRowColumnHeaders) to be stored per document? 

On the other hand, Gridlines on/off is stored per document.
Comment 11 ady 2023-08-16 01:36:07 UTC
(In reply to Heiko Tietze from comment #10)
> Why do you expert View > View Headers (uno:ViewRowColumnHeaders) to be
> stored per document? 

Because the creator of the specific spreadsheet has in mind what other users (of that specific spreadsheet) should see when opening the file and how that specific spreadsheet is supposed to be used by such users, in their own systems / LO installation.

In a similar way, a worksheet has some specific cells protected/blocked while some content-changing is allowed (on specific cells). Or some form, or fields, or Freeze Panes, or…

The setting is not about a user always using every_and_all spreadsheets without Row/Column headers.

The expectation (not just mine but from every spreadsheet user) is what is already supposed to happen, and has happened since... forever; except other bugs related to this feature (e.g. tdf#153295). Just test LO 3.3, or whichever other spreadsheet tool that includes this feature. In LO 7.6, the initially-limited situation described in tdf#153295 is much worse, described in this bug 156501; these are not duplicates of each other.

> 
> On the other hand, Gridlines on/off is stored per document.

As it should, for the same reasons I mentioned.
Comment 12 sebalis 2023-09-30 13:02:36 UTC
I noticed this problem a while ago, probably when I first upgraded to 7.6. I would very much like to see it solved. My current version is: 7.6.2.1 (X86_64) / LibreOffice Community, Build ID: 60(Build:1) (on Arch Linux).

I prefer not to show headers and in fact my template for new spreadsheets has View Headers switched off. If I create a document with that template, headers are hidden and remain hidden after I unhide them and save and reload. Also, I can replicate the original observation: If I open a test document that someone else created with visible headers and hide them, the change is not preserved after saving.

By opening a spreadsheet as a ZIP archive (in my instance by using file-roller), changing the following element in settings.xml, and reinserting the changed file in the archive, I was able to change the behaviour of my template and my test file:

<config:config-item config:name="HasColumnRowHeaders" config:type="boolean">false</config:config-item>

As a side observation, if I fully delete this value from settings.xml and subsequently open and save the spreadsheet in my current LibreOffice, the value gets recreated with a value of false. But the value remains unchangeable via LibreOffice.
Comment 13 ady 2024-06-05 10:03:36 UTC
I have been testing this behavior with different versions. It turns out that the problem is elsewhere. I will be opening a new report instead of this one. I am setting this report as invalid.
Comment 14 sebalis 2024-06-05 13:09:01 UTC
Thanks for taking a look, ady – please let us know where we can follow developments (when you can).