Bug 156506 - Cells not marked by marching ants when they were copied
Summary: Cells not marked by marching ants when they were copied
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha0+
Hardware: All Windows (All)
: medium normal
Assignee: Patrick (volunteer)
URL:
Whiteboard: target:24.2.0 target:7.6.0.3
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Cut-Copy
  Show dependency treegraph
 
Reported: 2023-07-28 13:47 UTC by Stefan_Lange_KA@T-Online.de
Modified: 2023-08-11 16:17 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan_Lange_KA@T-Online.de 2023-07-28 13:47:58 UTC
When in Calc cells are copied to the clipboard they are no longer marked by "marching ants"  (or otherwise).
Reproducing the behavior:
- create an new spreadsheet document
- enter something a cell
- select the cell and copy it to clipboard
Expected result: Cell is copied to clipboard and it is marked e.g. by marching ants
Actual result: Cell is copied to clipboard but it isn't marked.

The behavior was reproduced with
Version: 7.6.1.0.0+ (X86_64) / LibreOffice Community
Build ID: fe3ceb5c6ac1fcd52f0c2b20dcfc4d2505aedfe5
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded
and with
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 42f0422d19c4d0a2fb09654fb6d1d92e50f6dd5c
CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

I cannot reproduce the behavior with
Version: 7.6.0.1 (X86_64) / LibreOffice Community
Build ID: 776eaf34564cbf3f034a0ba1fd1d5c32ff9ccf1c
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL threaded
Comment 1 Eike Rathke 2023-07-28 15:28:12 UTC
That is coupled to Tools -> Options -> Calc -> General, Input Settings, Press Enter to paste and clear clipboard; reason is the ants are only there for that reason to indicate the Enter-Paste-Clear is active, if so they vanish once Enter-pasted-cleared.

See also bug 34686.

To me this is not a bug, unless very recently disabled completely, for which I currently don't have a recent build so can't check.
Comment 2 ady 2023-07-28 17:34:22 UTC
(In reply to Eike Rathke from comment #1)
> To me this is not a bug, unless very recently disabled completely, for which
> I currently don't have a recent build so can't check.

Just in case there is some relation:
bug 155414 comment 10
bug 155414 comment 13
bug 155414 comment 14
bug 155414 comment 15
Comment 3 Stéphane Guillou (stragu) 2023-07-29 08:06:39 UTC
Not reproduced in master build from today:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e26aeb882dd236adf19679d5df9b7ba5da1ed226
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Nor in gen VCL.

But confirmed by Michael in bug 155414 comment 16, so marking as Windows-only.
Comment 4 Stefan_Lange_KA@T-Online.de 2023-07-29 09:34:29 UTC
I can reproduce the behavior with the brand new Win-x86_64 build from master (https://dev-builds.libreoffice.org/daily/master/Win-x86_64@tb77-TDF/2023-07-29_10.58.35/):
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e26aeb882dd236adf19679d5df9b7ba5da1ed226
CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

Seems it is a Windows-only problem really ...
Comment 5 Stefan_Lange_KA@T-Online.de 2023-07-29 11:08:10 UTC
Hint: I do not need "marching ants". "Sleeping ants" would do for me, means a dashed line around the copied cells as marking.
But currently there is no marking at all.
Comment 6 Patrick (volunteer) 2023-07-29 14:46:10 UTC
(In reply to Stefan_Lange_KA@T-Online.de from comment #5)
> Hint: I do not need "marching ants". "Sleeping ants" would do for me, means
> a dashed line around the copied cells as marking.
> But currently there is no marking at all.

I cannot reproduce this on macOS. I see the "sleeping ants" when I have Accessibility > Display > Reduce motion checked in the System Preferences application and "marching ants" if it is unchecked.

Are any of the LibreOffice preferences shown in the following screen snapshot different on your machine?:

https://bugs.documentfoundation.org/attachment.cgi?id=188639
Comment 7 Stefan_Lange_KA@T-Online.de 2023-07-29 17:09:49 UTC
(In reply to Patrick Luby from comment #6)
> (In reply to Stefan_Lange_KA@T-Online.de from comment #5)
> > Hint: I do not need "marching ants". "Sleeping ants" would do for me, means
> > a dashed line around the copied cells as marking.
> > But currently there is no marking at all.
> 
> I cannot reproduce this on macOS. I see the "sleeping ants" when I have
> Accessibility > Display > Reduce motion checked in the System Preferences
> application and "marching ants" if it is unchecked.
> 
> Are any of the LibreOffice preferences shown in the following screen
> snapshot different on your machine?:
> 
> https://bugs.documentfoundation.org/attachment.cgi?id=188639

I have the same settings except "Show overwrite warning ..." is not set but this doesn't influence the behavior - I have tested.
As written in Comment 3 and reported in bug 155414 comment 16, 17 and 18 the problem reported in the bug seems to concern only Windows but not Linux and macOS.
Comment 8 Michael Weghorn 2023-07-30 00:30:28 UTC
See tdf#155414 comment 26:
This is a Windows-only regression from 

commit 9d68c794d67259a38de1465090f6f1e7fb588d62
Author: Patrick Luby
Date:   Fri Jul 21 19:55:02 2023 -0400

    tdf#155414 include system "reduce animation" preferences
    
    Allow the system's "reduce animation" preferences to disable the
    Calc animated border when copying a selection of cells.
    
    Also, fix failure to stop the animated border when a copy action is
    performed in a different document by cancelling the animated border.
    This transferable has lost ownership of the system clipboard so,
    in essence, the previous copy action that created this transferable
    has been cancelled.
    
    Change-Id: I4da6d557c5dbf653c38a99eb7a16d961843a41d6
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154752
    Tested-by: Jenkins
    Reviewed-by: Michael Weghorn
    Reviewed-by: Patrick Luby
Comment 9 Patrick (volunteer) 2023-07-30 13:19:07 UTC
(In reply to Michael Weghorn from comment #8)
> See tdf#155414 comment 26:
> This is a Windows-only regression from 
> 
> commit 9d68c794d67259a38de1465090f6f1e7fb588d62
> Author: Patrick Luby
> Date:   Fri Jul 21 19:55:02 2023 -0400
> 

I have reverted the portion of the above commit that stops the animated border when a copy action is performed in a different document by cancelling the animated border.

I'll post again when the fix is in the nightly master build.
Comment 10 Commit Notification 2023-07-30 14:38:23 UTC
Patrick Luby committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f324cba8600f9aa2c13e8531e1ce5467442b097b

tdf#156506 Fix failure to draw copy border on Windows

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Patrick (volunteer) 2023-07-30 17:34:33 UTC
I think that I have fixed this and the my fix should be in tomorrow's (31 July 2023) nightly builds:

https://dev-builds.libreoffice.org/daily/master/

Can any Windows users confirm that my fix works for you?
Comment 12 Commit Notification 2023-07-30 17:36:39 UTC
Patrick Luby committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/5662bb4eec10ac62aea79272047ed49cfa264d27

tdf#156506 Fix failure to draw copy border on Windows

It will be available in 7.6.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Stefan_Lange_KA@T-Online.de 2023-08-01 19:14:16 UTC
I have succesfully tested with both

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2a9e83a673300dfe15a3acc66acd560b2a7cae43
CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

and

Version: 7.6.1.0.0+ (X86_64) / LibreOffice Community
Build ID: b6ed7c7be2a94777ee9b1c4a5ddf77e3f5343efe
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL threaded

Result: In both ants are back - for me it is OK!
Comment 14 Patrick (volunteer) 2023-08-01 19:45:59 UTC
Marking bug as verified.
Comment 15 Commit Notification 2023-08-01 23:24:58 UTC
Patrick Luby committed a patch related to this issue.
It has been pushed to "libreoffice-7-6-0":

https://git.libreoffice.org/core/commit/233f81aaf9b74da8e36e5f5a3ed50a15ba11c6da

tdf#156506 Fix failure to draw copy border on Windows

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Stefan_Lange_KA@T-Online.de 2023-08-02 03:01:47 UTC
(In reply to Commit Notification from comment #15)
> Patrick Luby committed a patch related to this issue.
> It has been pushed to "libreoffice-7-6-0":
> 
> https://git.libreoffice.org/core/commit/
> 233f81aaf9b74da8e36e5f5a3ed50a15ba11c6da
> 
> tdf#156506 Fix failure to draw copy border on Windows
> 
> It will be available in 7.6.0.
> 
> The patch should be included in the daily builds available at
> https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
> information about daily builds can be found at:
> https://wiki.documentfoundation.org/Testing_Daily_Builds
> 
> Affected users are encouraged to test the fix and report feedback.

AFAIK on https://dev-builds.libreoffice.org/daily there are only builds for LO 7.6.1 now - and soon higher. The next LO 7.6.0 build I expect is RC3.
Is there an other place where one can find still now daily builds for LO 7.6.0?
Comment 17 Stefan_Lange_KA@T-Online.de 2023-08-11 16:17:51 UTC
Succesfully tested with
Version: 7.6.0.3 (X86_64) / LibreOffice Community
Build ID: 69edd8b8ebc41d00b4de3915dc82f8f0fc3b6265
CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

Ants are displayed!