Bug 156852 - Description field in Tools - Macros - Run Macro does not have borders
Summary: Description field in Tools - Macros - Run Macro does not have borders
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.5.6.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-21 20:43 UTC by Rafael Lima
Modified: 2023-10-03 18:25 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot showing the problem (37.47 KB, image/png)
2023-08-21 21:06 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2023-08-21 20:43:22 UTC
In the Macro Selector dialog, the Description field has no border.

To reproduce, simply open any LO app and go to Tools - Macro - Run Macro and notice the lack of border in the description box.

I was able to reproduce this issue in kf5, gtk3 and gen.

System info

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 6fa4e5965b2a79ae6735f4191a2261713a42356e
CPU threads: 12; OS: Linux 6.2; UI render: default; VCL: kf5 (cairo+wayland)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded

Also repro in

Version: 7.5.5.2 (X86_64) / LibreOffice Community
Build ID: 50(Build:2)
CPU threads: 12; OS: Linux 6.2; UI render: default; VCL: kf5 (cairo+wayland)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 4:7.5.5-0ubuntu0.23.04.1
Calc: threaded
Comment 1 Rafael Lima 2023-08-21 21:06:54 UTC
Created attachment 189085 [details]
Screenshot showing the problem
Comment 2 captnfab 2023-09-16 12:36:28 UTC
Confirmed in LO 7.5.6
Comment 3 Buovjaga 2023-10-03 15:28:52 UTC
Bibisected the change with linux-64-7.2 to da698585ea981e7bf210f3d7d52cdcf3f196a7bf
Macro Selector dialog: Remove extra padding and shadow

The change was deliberate and makes sense.
Comment 4 Rafael Lima 2023-10-03 17:33:24 UTC
(In reply to Buovjaga from comment #3)
> The change was deliberate and makes sense.

TBH I still feel this is a visual glitch.

In the patch the author says:

  >  To avoid giving the false sense of interactivity
  >  since it's meant to be solely an element to display text and
  >  an outline around can suggest waiting for some input/selection

However, simply removing the borders around the GtkTextView does not give that effect. To achieve that, a simple label should have been used (f.i. in File - Properties - General).

If the idea is to remove the sense of interactivity, we should consider replacing the GtkTextView for a simple GtkLabel containing the description.
Comment 5 Buovjaga 2023-10-03 18:25:38 UTC
(In reply to Rafael Lima from comment #4)
> (In reply to Buovjaga from comment #3)
> > The change was deliberate and makes sense.
> 
> TBH I still feel this is a visual glitch.
> 
> In the patch the author says:
> 
>   >  To avoid giving the false sense of interactivity
>   >  since it's meant to be solely an element to display text and
>   >  an outline around can suggest waiting for some input/selection
> 
> However, simply removing the borders around the GtkTextView does not give
> that effect. To achieve that, a simple label should have been used (f.i. in
> File - Properties - General).
> 
> If the idea is to remove the sense of interactivity, we should consider
> replacing the GtkTextView for a simple GtkLabel containing the description.

One thing I notice is that the text is selectable. Does GtkLabel provide selectability?