Bug 156943 - Comments on an indented paragraph get indented as well
Summary: Comments on an indented paragraph get indented as well
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.6.0.2 rc
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-26 21:56 UTC by Nadie Nada Nunca
Modified: 2023-08-30 13:34 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Bad formatting for comment (29.64 KB, image/jpeg)
2023-08-26 21:56 UTC, Nadie Nada Nunca
Details
Sample DOCX (12.95 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2023-08-26 23:48 UTC, Nadie Nada Nunca
Details
Bug present in latest nightly build (54.69 KB, image/jpeg)
2023-08-29 21:17 UTC, Nadie Nada Nunca
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nadie Nada Nunca 2023-08-26 21:56:07 UTC
Description:
Writer seems to “borrow” the formatting of the paragraph you are commenting for the comment itself. This leads to undesirable artifacts like the one in the attachment.

Steps to Reproduce:
1. Insert a heading with wide left and right margins in the document.
2. Write a comment for that paragraph.

Actual Results:
See attachment.

Expected Results:
The comment should appear just like any other comment.


Reproducible: Always


User Profile Reset: No

Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: TextDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no
Comment 1 Nadie Nada Nunca 2023-08-26 21:56:46 UTC
Created attachment 189168 [details]
Bad formatting for comment
Comment 2 m_a_riosv 2023-08-26 23:43:48 UTC
Please attach a sample file.
Comment 3 Nadie Nada Nunca 2023-08-26 23:48:28 UTC
Created attachment 189169 [details]
Sample DOCX

I forgot to clarify that I'm working with a DOCX file.
Comment 4 m_a_riosv 2023-08-27 13:16:36 UTC
Selecting the text in the comment and applying [Ctrl+M] cleaning the comment's format. Shows fine for me after save and reload.
Also, it is fine for me with a new file.
Version: 7.6.1.1 (X86_64) / LibreOffice Community
Build ID: c7cda394c5de06de37d8109c310df89a4d4c3a98
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: default; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
Comment 5 m_a_riosv 2023-08-27 13:17:01 UTC
Please test in safe mode, Menu/Help/Restart in Safe Mode
Comment 6 Nadie Nada Nunca 2023-08-27 22:27:02 UTC
It's the same in Safe Mode, only the text of the comment is drawn with a white background instead of the regular yellow of the rest of the comment.
Comment 7 m_a_riosv 2023-08-29 01:10:28 UTC
Right, this is a weird behavior, with 7.4, styles can not be applied to the comment. That seems possible from 7.5, where the issue appears.
The issue is solved for dev version.
I have not found a duplicated bug report. Neither in the released notes.

Looks as the 'comment' style was added with
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c9916d9be9c060d43fc063b76d70629162650fea
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded
added a new comment gets the 'comment' style.
Comment 8 Nadie Nada Nunca 2023-08-29 21:16:47 UTC
> The issue is solved for dev version.

It's not. See how it looks in the latest nightly build (new attachment).
Comment 9 Nadie Nada Nunca 2023-08-29 21:17:31 UTC
Created attachment 189233 [details]
Bug present in latest nightly build
Comment 10 m_a_riosv 2023-08-30 01:07:14 UTC
The comments not added with 24.2 are not modified, clearing direct formatting on comment gets it fine.
But test adding a new comment, and you can see how a new style 'comment' it's added in styles.
Comment 11 Nadie Nada Nunca 2023-08-30 09:36:32 UTC
Ah, I see! 

It's still strange to have comments inherit from the default style. If your document is double spaced, the comments will be double spaced as well. Comment style should sensibly be "its own thing".
Comment 12 m_a_riosv 2023-08-30 13:20:36 UTC
I don't think it is inherited from default, but a direct format for the comment.

If you agree, lets as worksforme.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 33ae7c12bbdf19b76ced472ca8aed6cf66477bbe
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded

If you want some enhancement on this, please open a new bug report.
Comment 13 Nadie Nada Nunca 2023-08-30 13:30:20 UTC
You can try it yourself. I inserted new comments in the same file, where the default text style is doublespaced, and the "Comment" style was generated as doublespaced as well. 

This is not the same as this bug, where the comment seems to follow the style of the paragraph being commented on. I consider it a different bug.
Comment 14 m_a_riosv 2023-08-30 13:34:06 UTC
Please open a new one.