Bug 156953 - save new file version on close doesn't work if "Don't Save" is clicked when closing
Summary: save new file version on close doesn't work if "Don't Save" is clicked when c...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: framework (show other bugs)
Version:
(earliest affected)
7.5.5.2 release
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: File-Versioning
  Show dependency treegraph
 
Reported: 2023-08-27 21:10 UTC by libreoffice
Modified: 2024-11-18 10:12 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description libreoffice 2023-08-27 21:10:26 UTC
If enabled, File->Versions->"Always save a new version on closing" does not save a new version if, when closing a file that has changes, you click "Don't Save".

My understanding from this: https://help.libreoffice.org/latest/en-US/text/shared/01/01190000.html?&DbPAR=SHARED&System=UNIX

...is that it should do so. If that's not the case, I believe it should do so (in cases where "Don't Save" is clicked by accident, as I recently did and lost a lot of work.)

Tested in LibreOffice Writer on Kubuntu 23.04, v7.5.5.2
Comment 1 Stéphane Guillou (stragu) 2023-09-11 08:29:47 UTC
I confirm the behaviour in 7.6.1, but my gut feeling is that we should keep it as it is currently: if the user takes the _explicit_ action "don't save", we should respect that. But it means the feature "always save a version on closing" could be labelled better, maybe "Always save a version when closing and saving".

And the documentation does not correspond to current behaviour: https://help.libreoffice.org/7.6/en-US/text/shared/01/01190000.html

(Just noting that versioning and filesave are not independent: saving a version automatically saves the file. So saying "I don't want to save the changes" necessarily means "I don't want to save a version".)

Marking as "new" as something needs to be done in any case. Either change the behaviour to match the label and documentation, or vice-versa.
Comment 2 libreoffice 2023-09-12 18:26:12 UTC
I guess it comes down to whether the versioning system is just a way to explicitly and intentionally save versions, or a way to guard against work/data loss. Sounds like it is intended more as the former. If it's also intended as the latter, I'd advocate for saving a version regardless (maybe an extra option in the dialog for that, if it doesn't feel too complicated/bloaty), but I do understand your reasoning re: the user saying "do not save". It's just the accidental click that I'm thinking of.

I like the re-phrase you suggest: "Always save a version when closing and saving".

Thanks for the attention to it.