Description: At 7.6, all Libreoffice instances open with the title "Libreoffice 7.6" At 7.5 and before, they got the filename as a title e.g."calendar.ods". Seems to affect all components: I only tried Words, Impress and Calc so far (15 mins after install) Steps to Reproduce: 1.Open any document, spreadsheet, &c. 2.You will see "Libreoffice 7.6" in the title bar instead of the name of what you opened 3. Actual Results: "Libreoffice 7.6" in the title bar Expected Results: name of opened document in the title bar Reproducible: Always User Profile Reset: No Additional Info: LibreOffice 7.6.0.3 69edd8b8ebc41d00b4de3915dc82f8f0fc3b6265 (from libreoffice --version: can't select & paste from Help - About LibreOffice
Cannot reproduce with: Version: 7.6.0.3 (AARCH64) / LibreOffice Community Build ID: 69edd8b8ebc41d00b4de3915dc82f8f0fc3b6265 CPU threads: 4; OS: Linux 6.1; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.UTF-8); UI: de-DE Flatpak Calc: threaded on Debian12 (Bookworm) with Gnome-desktop
More details of my setup (assembled manually) Version: 7.6.0.3 (X86_64) / LibreOffice Community Build: 69edd8b8ebc41d00b4de3915dc82f8f0fc3b6265 CPU threads: 16; OS: Linux 6.4; UI render: default; VCL: gtk3 Locale: en-GB (en_US); UI: en-GB Misc: Calc: threaded on Slackware 15.0 with fvwm 2.6.6 (Slackware
git bisect of branch libreoffice-7-6-0 identifies: f7d4efc02118a92a3f3cb17ea131674e88907a7b is the first bad commit commit f7d4efc02118a92a3f3cb17ea131674e88907a7b Author: Radhey Parekh <radhey.parekh@gmail.com> Date: Mon Jan 16 02:13:53 2023 +0530 tdf#146638 In a titlebar, separator is changed from a hyphen to an emdash Change-Id: Ibf79dfd4c3e2f44ba4564567cd5e3f3650095719 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145542 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> framework/inc/strings.hrc | 1 + framework/source/fwe/helper/titlehelper.cxx | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) This is the patch: git diff 5ed9bb8bdcb1bee63d89909eed82110da31edfe5 f7d4efc02118a92a3f3cb17ea131674e88907a7b diff --git a/framework/inc/strings.hrc b/framework/inc/strings.hrc index 18b372915b9b..182c3cf120ac 100644 --- a/framework/inc/strings.hrc +++ b/framework/inc/strings.hrc @@ -36,6 +36,7 @@ #define STR_CLEAR_RECENT_FILES NC_("STR_CLEAR_RECENT_FILES", "Clear List") #define STR_CLEAR_RECENT_FILES_HELP NC_("STR_CLEAR_RECENT_FILES_HELP", "Clears the list with the most recently opened files. This action can not be undone.") #define STR_REMOTE_TITLE NC_("STR_REMOTE_TITLE", " (Remote)") +#define STR_EMDASH_SEPARATOR NC_("STR_EMDASH_SEPARATOR", " â ") #define STR_SAFEMODE_TITLE NC_("STR_SAFEMODE_TITLE", " (Safe Mode)") #define STR_TOOLBAR_TITLE_ADDON NC_("STR_TOOLBAR_TITLE_ADDON", "Add-On %num%") #define STR_FULL_DISC_RETRY_BUTTON NC_("STR_FULL_DISC_RETRY_BUTTON", "Retry" ) diff --git a/framework/source/fwe/helper/titlehelper.cxx b/framework/source/fwe/helper/titlehelper.cxx index aa4e8f0b2010..51025f71e4a5 100644 --- a/framework/source/fwe/helper/titlehelper.cxx +++ b/framework/source/fwe/helper/titlehelper.cxx @@ -536,7 +536,10 @@ void TitleHelper::impl_appendProductName (OUStringBuffer& sTitle) if (!name.isEmpty()) { if (!sTitle.isEmpty()) - sTitle.append(" - "); + { + OUString separator (FwkResId (STR_EMDASH_LANG=en_USSEPARATOR)); + sTitle.append(separator); + } sTitle.append(name); } } This falls down in a non-UTF8 locale, e.g. LANG=en_US as I have. REPRODUCER: Ensure no libreoffice instances running, enter e.g. LANG=en_US, start libreoffice on some file, put LANG back to what it was. MY WORKAROUND: LANG=en_US.UTF-8; libreoffice ~/calendar.ods& LANG=en_US SUGGESTED FIX: either check whether locale is UTF-8 with `nl_langinfo(CODESET)` (or nl_langinfo_l), or revert f7d4efc02118.
No repro with: Version: 7.6.1.1 (X86_64) / LibreOffice Community Build ID: c7cda394c5de06de37d8109c310df89a4d4c3a98 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded No repro either using LANG=en_US: Version: 7.6.1.1 (X86_64) / LibreOffice Community Build ID: c7cda394c5de06de37d8109c310df89a4d4c3a98 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-US (en_US); UI: en-US Calc: threaded But I get: Gtk-WARNING **: 09:54:33.645: Locale not supported by C library. Using the fallback 'C' locale. So I tried commenting out these lines (separately) in /etc/locale.gen : en_US ISO-8859-1 and then runnning: sudo locale-gen Which makes the message disappear, but still no repro. And locale-gen will not accept a simple "en_US". Radhey, can you please have a look?
Reproduces on a freshly-created Slackware VM. Such a VM boots to runlevel 3 (VT console). If you then `export LANG=en_US; startx`, you have the potential to observe the errant banner. In the xterm from which you start libreoffice, if LANG is en_US then libreoffice window title will be wrong, add .UTF8 to LANG and it will be right. LibreOffice 7.6.0.3 69edd8b8ebc41d00b4de3915dc82f8f0fc3b6265
Let's mark as new as there is a bisect. I still haven't been able to reproduce though.
Is there any particular reason why you use or have to use a non-UTF8 locale? Don't other parts of the UI have issues rendering some characters?
Actually no. I did mistakenly think UTF-8 would mess up my input settings. Am using UTF-8 now. OK with me if you close this.
OK, let's close as "won't fix" but it someone can make a strong case for having a fallback for an ASCII locale, we can of course reconsider. Thank you!