Bug 157009 - Android: F-Droid listing lacks app icon
Summary: Android: F-Droid listing lacks app icon
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Android Viewer (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha1+
Hardware: All Android
: medium trivial
Assignee: Michael Weghorn
URL: https://f-droid.org/en/packages/org.d...
Whiteboard: target:24.8.0 target:24.2.4 target:25...
Keywords:
Depends on:
Blocks: Icon-Themes-Code
  Show dependency treegraph
 
Reported: 2023-08-30 11:12 UTC by steve
Modified: 2024-07-18 15:02 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description steve 2023-08-30 11:12:32 UTC
Description:
F-Droid listing of LibreOffice Viewer lacks app icon:
https://f-droid.org/en/packages/org.documentfoundation.libreoffice/

Steps to Reproduce:
Visit https://f-droid.org/en/packages/org.documentfoundation.libreoffice/ and see the listing has no app icon.

Actual Results:
No app icon

Expected Results:
Listing should show with app icon


Reproducible: Always


User Profile Reset: No

Additional Info:
N/A
Comment 1 Michael Weghorn 2023-08-31 09:39:24 UTC
I've submitted a merge request to F-Droid that updates the app to 7.6.0 and adds an icon:
https://gitlab.com/fdroid/fdroiddata/-/merge_requests/13643

Closing as NOTOURBUG because it has to be addressed there, not in our own repos.
Comment 2 Michael Weghorn 2023-09-01 08:20:01 UTC
(In reply to Michael Weghorn from comment #1)
> I've submitted a merge request to F-Droid that updates the app to 7.6.0 and
> adds an icon:
> https://gitlab.com/fdroid/fdroiddata/-/merge_requests/13643
> 
> Closing as NOTOURBUG because it has to be addressed there, not in our own
> repos.

They don't accept new icons in their repo any more, s. the discussion in that MR. The only way is now to support either Fastlane or Triple-T metadata for providing it.

That's something that will have to be done in our repo. Setting to NEW.
Comment 3 Sophie Sipasseuth 2023-11-21 13:37:32 UTC
This bug is still present.
There is no icon for LibreOffice Viewer in the F-Droid app.
Instead, there is a default icon, that of F-Droid, grayed out.
Comment 4 Sophie Sipasseuth 2023-11-21 13:53:10 UTC
Version 7.6.3.2.0+
Comment 5 Commit Notification 2024-05-16 10:15:06 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/69189de8fa9a9d4973a4304a82780d32e79fbe6f

tdf#157009 android: Add icon symlink for F-Droid

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Michael Weghorn 2024-05-16 10:20:13 UTC
According to the discussion in https://gitlab.com/fdroid/fdroiddata/-/merge_requests/13643 , the commit from comment 5 should in my understanding make the icon show up in F-Droid after the next update. Let's see whether that's actually the case or whether something else is needed.
Comment 7 Commit Notification 2024-05-16 19:46:30 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/6460b76852b69f428ed26aba3877e9853ec22555

tdf#157009 android: Add icon symlink for F-Droid

It will be available in 24.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2024-06-28 14:37:16 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/802a10654151c00302bc7b7479673101f2d47b20

tdf#157009 android: Add missing subdir for Triple-T/F-Droid icon

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2024-06-28 21:07:08 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/89834ae1ec20fb7c242e697966037e925e1d44f1

tdf#157009 android: Add missing subdir for Triple-T/F-Droid icon

It will be available in 24.2.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Michael Weghorn 2024-06-28 21:22:55 UTC
(In reply to Michael Weghorn from comment #6)
> According to the discussion in
> https://gitlab.com/fdroid/fdroiddata/-/merge_requests/13643 , the commit
> from comment 5 should in my understanding make the icon show up in F-Droid
> after the next update. Let's see whether that's actually the case or whether
> something else is needed.

That was not sufficient, but I've submitted another change that should hopefully actually make the icon show up after the next update of the app in F-Droid.
Comment 11 Commit Notification 2024-06-29 01:13:38 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/9886091995865cb1978cb67e6074b1631a0072fc

tdf#157009 android: Add missing subdir for Triple-T/F-Droid icon

It will be available in 24.8.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 steve 2024-07-16 10:13:16 UTC
Progres: LibreOffice Viewer now shows with icon in F-Droid Basic listing, but not (yet?) in F-Droid weblisting at https://f-droid.org/en/packages/org.documentfoundation.libreoffice/

Is this a caching problem or is additional action required?
Comment 13 Michael Weghorn 2024-07-16 10:51:01 UTC
(In reply to steve from comment #12)
> Progres: LibreOffice Viewer now shows with icon in F-Droid Basic listing,
> but not (yet?) in F-Droid weblisting at
> https://f-droid.org/en/packages/org.documentfoundation.libreoffice/
> 
> Is this a caching problem or is additional action required?

Great, thanks for the update. Then the last commit actually fixed it, together with the F-Droid update to 24.2.5.

The website still shows 24.2.4, and should show the proper icon as well once it has been updated to 24.2.5.

From https://gitlab.com/fdroid/wiki/-/wikis/FAQ#how-long-does-it-take-for-my-app-to-show-up-on-website-and-client :

> Please also note that the website is updated asynchronously – so while the index might already have reached your local client, website might still be a bit behind.
Comment 14 steve 2024-07-18 15:02:05 UTC
Thanks I was not aware of website and client not being synchronous for F-Droid.
Setting to verified as icon shows as expected in client. Thanks for your work on this.