Bug 157095 - Content control opens "Review fields" dialog box instead of inline editing
Summary: Content control opens "Review fields" dialog box instead of inline editing
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: DOCX-Content_Control
  Show dependency treegraph
 
Reported: 2023-09-05 00:10 UTC by Hossein
Modified: 2023-12-27 19:28 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
DOCX: document containing a content control (12.17 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2023-09-05 00:10 UTC, Hossein
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hossein 2023-09-05 00:10:23 UTC
Created attachment 189354 [details]
DOCX: document containing a content control

Description:
With the recent improvements on content controls, LibreOffice no longer opens dialog boxes for editing content controls. On the other hand, it seems that the old behavior is not completely removed for all the content control types.

Steps to Reproduce:
1. Open the attachment
2. Double click on the text.

Actual Results:
The "Review Fields" dialog box comes up.

Expected Results:
The editing should happen inline, just like other content controls. This is also the behavior in MS Word.

Reproducible: Always


User Profile Reset: No


Additional Info:
Reproducible with the latest LO 24.2 dev master:
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 410632ac4b8a280e0993e665ffa9cfede8326b49
CPU threads: 20; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_DE); UI: en-US
Calc: CL threaded

This is the relevant part from the OOXML (document.xml):

      <w:sdtContent>
        <w:p w14:paraId="19DF63DE" w14:textId="3A8E6075" w:rsidR="007D3BDF" w:rsidRPr="007D3BDF" w:rsidRDefault="007D3BDF" w:rsidP="007D3BDF">
          <w:pPr>
            <w:rPr>
              <w:lang w:val="en-US"/>
            </w:rPr>
          </w:pPr>
          <w:r>
            <w:rPr>
              <w:lang w:val="en-US"/>
            </w:rPr>
            <w:t>This is inside a content control</w:t>
          </w:r>
        </w:p>
      </w:sdtContent>
Comment 1 Stéphane Guillou (stragu) 2023-09-19 07:51:15 UTC
Thanks Hossein.
I can see the dialog after a double-click on the field.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b3fdd999f87312447d03915585812b3a5cd48141
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Do you know where the deprecation of that dialog was tracked?
Comment 2 Gabor Kelemen (allotropia) 2023-12-27 19:28:04 UTC
This seems to have been solved recently in 24.2 with:

https://git.libreoffice.org/core/+/5082d50d24c3fec4487c724a15eb0d54a82ecd0d

author	Jaume Pujantell <jaume.pujantell@collabora.com>	Wed Sep 13 08:58:21 2023 +0200
committer	Jaume Pujantell <jaume.pujantell@collabora.com>	Wed Oct 11 15:19:58 2023 +0200

writerfilter: use content controls for text in block SDTs

Thanks Jaume!