Bug 157106 - Paragraph style change is not tracked if it affects more than one paragraph
Summary: Paragraph style change is not tracked if it affects more than one paragraph
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Track-Changes-TextFormatting
  Show dependency treegraph
 
Reported: 2023-09-05 20:54 UTC by Eyal Rozenberg
Modified: 2023-09-29 10:18 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Document for reproducing the bug (14.14 KB, application/vnd.oasis.opendocument.text)
2023-09-05 20:54 UTC, Eyal Rozenberg
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2023-09-05 20:54:55 UTC
Created attachment 189374 [details]
Document for reproducing the bug

When in track changes mode, 

* If we select an entire paragraph and switch its paragraph style, no change is recorded.
* If we place the cursor at some point within the paragraph and switch the paragraph style, at least one change is tracked (and perhaps sometimes more than one? Or - applying Undo results in yet another tracked change?)


In the attached document, try selecting the entire second paragraph and change it from foo to bar. Then, undo, and try doing the same with no selection and the cursor in the middle of the second paragraph. Note the active icons on the Changes toolbar as you do so.


Note: This bug is not about DF, i.e. not about Format | Paragraph but about switching between named styles.
Comment 1 Stéphane Guillou (stragu) 2023-09-28 15:30:04 UTC
For me, it works in both cases: change denoted in as a line in the left margin, and change listed in the "Edit > Track Changes > Manage" dialog.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2902ab24ecc5ffbf4907ea83b2028508b9de6364
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: es-MX (en_AU.UTF-8); UI: en-US
Calc: threaded

Version: 7.6.2.1 (X86_64) / LibreOffice Community
Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Can you please test again with a clean profile and an updated version?
Comment 2 Eyal Rozenberg 2023-09-29 08:36:24 UTC
(In reply to Stéphane Guillou (stragu) from comment #1)
> Can you please test again with a clean profile and an updated version?

Reproduced again with a clean profile on each of:

Version: 7.6.0.3 (X86_64) / LibreOffice Community
Build ID: 69edd8b8ebc41d00b4de3915dc82f8f0fc3b6265
CPU threads: 4; OS: Linux 6.4; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US

and:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f8e591ab9182e0a61c4ae5b8f77b166fcaeaa877
CPU threads: 4; OS: Linux 6.4; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US

How did you select the paragraph for the first part of the reproduction instructions? Did you use the keyboard or the mouse? I used the keyboard and selected up until right before the first char of the subsequent paragraph; maybe that could have something to do with it?
Comment 3 Stéphane Guillou (stragu) 2023-09-29 10:18:32 UTC
(In reply to Eyal Rozenberg from comment #2)
> How did you select the paragraph for the first part of the reproduction
> instructions? Did you use the keyboard or the mouse? I used the keyboard and
> selected up until right before the first char of the subsequent paragraph;
> maybe that could have something to do with it?

I used triple-click, but just tested your method and now I see the subtle difference:

- If you select up to after the final dot, change is recorded/shown.
- If you select up to before "This" in the next paragraph (which actually changes the style of the _two_ paragraphs), the change is not recorded/shown.

The issue is that changing the paragraph style of more than 1 paragraph at once is not recorded.

Marking as "new".

This started with libreoffice-7.3.0.0.alpha1, when tracking such a change was first implemented. László actually mentioned that limitation already in bug 144272 comment 5:

> Note: selecting multiple paragraphs to modify their
> styles at once doesn't record the changes, yet, because
> multi-paragraph ParagraphFormat redline range hasn't
> supported by AppendRedline().