Bug 157125 - Table bottom border rendered wrong immediately after property change
Summary: Table bottom border rendered wrong immediately after property change
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.0.3 release
Hardware: All All
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Writer-Tables
  Show dependency treegraph
 
Reported: 2023-09-06 19:58 UTC by Jim Avera
Modified: 2024-04-09 23:26 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot #1 (see description) (8.03 KB, image/png)
2023-09-06 19:59 UTC, Jim Avera
Details
Screenshot #2 (11.06 KB, image/png)
2023-09-06 20:00 UTC, Jim Avera
Details
Screenshot #1 using timer (see description) (111.66 KB, image/png)
2023-09-06 20:04 UTC, Jim Avera
Details
test ODT (9.38 KB, application/vnd.oasis.opendocument.text)
2023-09-07 12:34 UTC, Stéphane Guillou (stragu)
Details
Result with latest linux bibisect as of today (97.03 KB, image/png)
2023-09-07 13:57 UTC, Miklos Vajna
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Avera 2023-09-06 19:58:29 UTC
Description:
If Table border colors are changed, the bottom border's color does not change on screen until the user clicks somewhere else; all the other borders are re-rendered in the new color immediately after OK is clicked. 

Please see attached screen shots

shot #1: Immediately after clicking OK to change border color to red
shot #2: After clicking in another paragraph not in the table


Steps to Reproduce:
1. (in Writer) Table->Insert Table (take defaults to get 2x2 table)
2. Click in the table; then do Table->Select->Table
3. Table->Properties
4. Click the icon for all borders; set extra thick borders (still black); OK
5. Repeat steps 2-4 but just change the border color to red; click OK

Actual Results:
The borders other than the bottom border change to red.  The bottom border remains black.  Clicking *inside* the table does not change this, but as soon as you click outside the table, the bottom border color changes.

Expected Results:
All borders rendered in the new color


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 78d9d0d8dccb6fd8952435b8a13d525c7606f467
CPU threads: 12; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Jim Avera 2023-09-06 19:59:52 UTC
Created attachment 189394 [details]
Screenshot #1 (see description)
Comment 2 Jim Avera 2023-09-06 20:00:13 UTC
Created attachment 189395 [details]
Screenshot #2
Comment 3 Jim Avera 2023-09-06 20:04:54 UTC
Created attachment 189396 [details]
Screenshot #1 using timer (see description)
Comment 4 Jim Avera 2023-09-06 20:06:57 UTC
This may be relevant: I could not easily get a screenshot of the problem because it "fixed itself" the moment I clicked outside of LO to do the screenshot (I had to use the screenshot tool's timer mode to get it).

So it is not "clicking" that finishes the rendering, but (perhaps) any mouse focus change.

So this might be a problem with interacting with XOrg.
Comment 5 Stéphane Guillou (stragu) 2023-09-06 23:40:59 UTC Comment hidden (obsolete)
Comment 6 Stéphane Guillou (stragu) 2023-09-07 12:30:16 UTC
Hm I am getting different results between gen and gtk3 VCL plugins (and between release binaries vs bibisect binaries), so I ended up bibisecting for gtk3 only, with linux-64-6.4 repo to first bad commit 7e5766c677e820a05f3ea51489ffba0c004d9742 which point to core commit da2000648b852047ec9d865891539c28ada97730 which is a cherrypick of:

commit d4ea54e18346a35590933dd1e8b83d1c12a741de
author	Miklos Vajna Mon Dec 16 21:01:13 2019 +0100
committer	Miklos Vajna Tue Dec 17 09:03:25 2019 +0100
tdf#128567 sw: fix flicker of table selection highlight
Reviewed-on: https://gerrit.libreoffice.org/85240

Miklos, can you please have a look?
Comment 7 Stéphane Guillou (stragu) 2023-09-07 12:34:05 UTC
Created attachment 189414 [details]
test ODT

To be completely clear, these are the steps I used for the bibisect:

1. Open attached ODT
2. Ctrl + A > context menu > Table Properties > Borders
3. Change border colour to Lime, click OK

Result: parts of bottom and side borders don't update to new colour until next action.
Comment 8 Miklos Vajna 2023-09-07 13:57:30 UTC
Created attachment 189416 [details]
Result with latest linux bibisect as of today

Hm, I have trouble reproducing this. Here is what I tried:

- git clone https://bibisect.libreoffice.org/linux-64-24.2
- that currently gives a binary of core.git commit d8dbf35c48698e49c527d740853ce4edc4f1afa9 (set java_websocket source as UTF-8, 2023-09-05)
- SAL_USE_VCLPLUGIN=gtk3 instdir/program/soffice /path/to/tdf157125/orig.odt (which is attachment 189414 [details])
- used your repro steps
- border color looks OK, I attach what I see.

Do I miss something or was this fixed in the meantime? Thanks.
Comment 9 Miklos Vajna 2023-09-08 14:36:06 UTC
In the meantime I tried the original problem from the above commit and it seems this flicker doesn't happen when I revert it, so it would be probably OK to get rid of the change, but I would like to avoid a blind fix.
Comment 10 Stéphane Guillou (stragu) 2023-09-28 16:45:52 UTC
(In reply to Miklos Vajna from comment #9)
> In the meantime I tried the original problem from the above commit and it
> seems this flicker doesn't happen when I revert it, so it would be probably
> OK to get rid of the change, but I would like to avoid a blind fix.

Hm now I can't reproduce in oldest of linux-64-24.2 bibisect repo, not in a recent daily build:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2902ab24ecc5ffbf4907ea83b2028508b9de6364
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: es-MX (en_AU.UTF-8); UI: en-US
Calc: threaded

But I still can reproduce in 7.6.2.1 and 7.5.7.1 releases.

So difference between the bibisect/daily builds vs release builds? *shrugs*
Comment 11 QA Administrators 2024-03-27 03:14:19 UTC Comment hidden (obsolete)
Comment 12 Jim Avera 2024-04-09 23:26:28 UTC
Seems to have been fixed.
WFM with 24.8 alpha