Bug 157227 - "Search Results" dialog (from find & replace in "All sheets") should use markup to make the matching part of the strings easier to spot
Summary: "Search Results" dialog (from find & replace in "All sheets") should use mark...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Find&Replace-Dialog
  Show dependency treegraph
 
Reported: 2023-09-13 19:21 UTC by Jeff Fortin Tam
Modified: 2023-09-27 18:34 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot showing how the "needle" term is not clearly identified among the search results items' strings (50.98 KB, image/png)
2023-09-13 19:22 UTC, Jeff Fortin Tam
Details
screenshot of VoyantTools' Contexts widget (140.10 KB, image/png)
2023-09-14 08:06 UTC, Stéphane Guillou (stragu)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Fortin Tam 2023-09-13 19:21:06 UTC
Description:
In a long list of search results, matching parts of strings should be easier to spot.

Steps to Reproduce:
1. Ctrl+H in Calc
2. Check "All sheets"
3. Run a "Find all" (or "Replace all") query

Actual Results:
All row items in the "Search results" dialog are shown in plain text, with no visual indication of where the matches happen in the strings

Expected Results:
Either use bold text (ideally) or highlighting (suboptimal, because we shouldn't depend only on color) to mark up the matching portions of the strings, so that it's easy to see what part of each row has been matching.


Reproducible: Always


User Profile Reset: No

Additional Info:
Tested on version: 7.6.0.3 (X86_64) / LibreOffice Community
Build ID: 69edd8b8ebc41d00b4de3915dc82f8f0fc3b6265
CPU threads: 8; OS: Linux 6.4; UI render: default; VCL: gtk3
Locale: fr-CA (en_CA.UTF-8); UI: en-US
Flatpak
Calc: threaded
Comment 1 Jeff Fortin Tam 2023-09-13 19:22:18 UTC
Created attachment 189556 [details]
Screenshot showing how the "needle" term is not clearly identified among the search results items' strings
Comment 2 Stéphane Guillou (stragu) 2023-09-13 22:07:23 UTC
I agree that this would be a welcome tweak to the Search Results dialog, especially for cells with long strings.
Just copying UX/Design team to hear their opinion.

Tested in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 43df1237a091e2b0f4495d5a7e959f7beaab025d
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 3 Heiko Tietze 2023-09-14 07:30:49 UTC
Sounds reasonable. Alternatively we could just elide the text so the search term is guaranteed to be shown. "Cat and dogs are the needle in the haystack" would become "...the needle in..." then.
Comment 4 Stéphane Guillou (stragu) 2023-09-14 08:06:14 UTC
Created attachment 189564 [details]
screenshot of VoyantTools' Contexts widget

For some inspiration, here's how VoyantTools' "Contexts" widget does it (but it is admittedly more about exploring what is around the search term).
The size of the context is customisable, for both the single-row and expanded views.