Created attachment 189853 [details] Example file to demonstrate security warnings LibreOffice can issue a warning when a document with hidden information, such as document versions or recorded changes, is saved, signed, printed, or exported to a PDF. In addition, personal information, such as the author of a document or comment, can be automatically removed by LibreOffice when the document is the document is saved. The functionality is intended to prevent sensitive information in a document from being overlooked and accidentally shared. By default these options are not enabled. In the current implementation, if the appropriate configuration options are enabled, a warning will be issued and/or the personal information will be removed each time the document is saved. This can quickly be perceived as annoying, causing approval fatique. There is a risk that the warning is routinely clicked away. In addition, cooperative work on the document is made more difficult, for example, because the author can no longer understand a change. In the project it is to be discussed and then implement how a less disruptive warning can be created here. One possibility to consider would be to replace the individual warnings with an infobar at the top of the page. 1. Go to Options - Security 2. Press Options button on top 3. Enable all 4 Security Warnings 4. Open attached file 5. Try to Save it as PDF or Digitally sign or Save as odt or Print -> You get an annoying popup window. This could be less intrusive by using an infobar, laying groundwork to enable these features by default. Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d43e2a9214c0d06465a3027231948760e65ad4ee CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: hu-HU (hu_HU.UTF-8); UI: en-US Calc: threaded
Created attachment 189854 [details] The warning dialog before digitally signing the file
Created attachment 189855 [details] The warning dialog before printing the file
Created attachment 189856 [details] The warning dialog before PDF exporting the file
Created attachment 189857 [details] The warning dialog before saving the file
I don't see much annoyance in the message box, as a matter of privacy you probably want an explicite warning. And I wonder how to show a list in the infobar string. "This document contains: <A>, <B>, <C>. Continue?" might exceed the available space. For the dialog it would be nice to have bullets for the items and some "[x] Show this warning" to suppress the information without fiddling around with the options dialog could be helpful. Other opinions?
Created attachment 189997 [details] demo_picture I think it would look like something like that? (demo_picture) But of course the infobar cannot stop the saving/pdf export/signing processes.
(In reply to Balázs Varga (allotropia) from comment #6) > But of course the infobar cannot stop the saving/pdf export/signing processes. Which makes the question "Do you want to continue" pointless. If we go this way the function could either remove the features on save/print, ie. TC, notes, comments, versioning, authorship etc., or inform that it contains those information. Somewhat weird for printing, however.
> Which makes the question "Do you want to continue" pointless. If we go this > way the function could either remove the features on save/print, ie. TC, > notes, comments, versioning, authorship etc., or inform that it contains > those information. Somewhat weird for printing, however. Yes, agree, I just forget the "Do you want to continue" in the infobar. But yeah no point of that.
(In reply to Heiko Tietze from comment #7) > (In reply to Balázs Varga (allotropia) from comment #6) > > But of course the infobar cannot stop the saving/pdf export/signing processes. > Which makes the question "Do you want to continue" pointless. If we go this > way the function could either remove the features on save/print, ie. TC, > notes, comments, versioning, authorship etc., or inform that it contains > those information. Somewhat weird for printing, however. Removing the personal data is another checkbox in the settings dialog, and there is a separate idea for that -> in See Also. The button on the demo picture by Balazs is a stub for that. For these checkboxes showing a warning is enough. (and not showing the button if the remove private data is not enabled, may make sense too) For printing may sound weird - but you may realistically NOT want to print comments or TC under some circumstances.
Also another independent angle: we may show the infobar when the user pushes some UNO commands. But when should we automatically hide it? Like: ok you have been warned, but now you can do whatever you wish, this is not so super important to need explicitly closed or to keep indefinitely until the document is closed. Maybe it is possible/sensible to hide it when another UNO command is triggered or on typing new text.
Balazs Varga committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1f440348eb0892fd2c9597806d87b5fe9d60d49a tdf#157482 UI: Turn Security Warnings popup windows into infobars It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thanks, Balazs Varga, it works for all 4 cases. Verified with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 0875594b381e2765f2b6413074c470f9eec33201 CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded
I guess we should also mention Samuel's f41627ab60372345be646c53d967b65be43b562f here, and maybe at 7.6 to the target? It doesn't have an attached ugzilla ticket. Also, I tested in 7.6.3 and a recent trunk build, and I can't see an infobar on fileopen on ODS or ODB files with macros (High macro security level, the default). 7.5 would warn that the document had macros on the same default setting, so no notification at all is a loss in my opinion. Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 7d357628d6e8ce3f9e3c3a567ada21f02bce8d42 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Version: 7.6.3.1 (X86_64) / LibreOffice Community Build ID: c4af5b1259bceea6e979e6fe2435dbee7a5a87c2 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded