Bug 157575 - Misleading dialog label in Security Warnings
Summary: Misleading dialog label in Security Warnings
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:24.2.0
Keywords:
Depends on:
Blocks: Options-Dialog
  Show dependency treegraph
 
Reported: 2023-10-03 12:19 UTC by Gabor Kelemen (allotropia)
Modified: 2023-10-09 09:29 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
Dialog with problematic label (96.16 KB, image/png)
2023-10-03 12:19 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2023-10-03 12:19:59 UTC
Created attachment 189976 [details]
Dialog with problematic label

The Security Options and Warnings dialog contains a slightly misleading label:
"Warn if document contains recorded changes, versions, hidden information or notes:"

However when looking in the implementation, it becomes clear that it does not warn about "hidden information" such as hidden characters, paragraphs or sections or anything like that - instead, the "hidden information" here is a collective term for the recorded changes or (document) versions or notes: 

https://cgit.freedesktop.org/libreoffice/core/tree/sfx2/source/doc/objstor.cxx#n3120
(see SfxObjectShell::QueryHiddenInformation )

Suggestion is to drop the "hidden information" from the above label.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0c4913e03e8427a576138601958f2dbf13b8c37b
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

Text is like this in 3.3 - no regression.
Comment 1 Commit Notification 2023-10-09 09:10:59 UTC
Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9f44f9fad759dea644356b67b9cd0fab030e8b77

tdf#157575 Clarify labels content in Security Options dialog

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.