Bug 157662 - Writer: Tracked changes split into many parts require more Accept/Reject
Summary: Writer: Tracked changes split into many parts require more Accept/Reject
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Attila Szűcs
URL:
Whiteboard: target:24.2.0
Keywords:
Depends on:
Blocks: Track-Changes
  Show dependency treegraph
 
Reported: 2023-10-09 02:43 UTC by Attila Szűcs
Modified: 2024-09-23 09:03 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
sample docx file with 1 insert, ans some delete (12.82 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2023-10-09 02:45 UTC, Attila Szűcs
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Attila Szűcs 2023-10-09 02:43:48 UTC
Description:
A sample docx file made by word, has 1 insertion, and several deletion.
We can accept or reject the insertion with 1 click, and rejection the insertion remove all deletions as well as they are meaningless.

Writer import it as 11 tracked changes where 5 of it is deleted as well.
While it is good to see the relations of the changes, it is harder to reject / accept.
To reject the insertion we need to reject like 6-11 times.
To accept we need to accept the 6 inserion that is not deleted... (and about the deleted one... we cannot accept only the insertion under it, to leave the delete changes for later decision.)

Note: "reject all" is not designed for this, even that in this simple sample case it would do what we want... because that would reject all other changes (if there would nny), even those that are unrelated to this insertion.


Steps to Reproduce:
1. Open the file
2. open manage changes sidebar
3. and try to reject or accept the insert

Actual Results:
it will reject or accept only the selected part of the insertion leaving all else there.

Expected Results:
At reject, it should remove all changes
At accept, it should remove all insertion changes, and leave only the delete changes... but even there it should remove their insertion child, as that is accepted.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 0a90b90048313fb43f8c5d7461f58dafec276600
CPU threads: 6; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: CL threaded
Comment 1 Attila Szűcs 2023-10-09 02:45:35 UTC
Created attachment 190090 [details]
sample docx file with 1 insert, ans some delete
Comment 2 Commit Notification 2023-10-14 09:55:47 UTC
Attila Szűcs committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/52fa7aed48632166e064e6a227e034f0981c4205

tdf#157662 SW: redline: accept/reject done for all parts

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2023-10-31 15:27:37 UTC
Attila Szűcs committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bfeb6375a96d75ed7117f1581b0a0d7cb0d236ca

tdf#157662 SW: fix connected area calculation

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Timur 2024-09-13 12:20:16 UTC
Seems to be fixed like described. Please see if unintentionally left open.