Bug 157811 - Swapped tooltips for stepped line types of line chart
Summary: Swapped tooltips for stepped line types of line chart
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
7.1.0.3 release
Hardware: All All
: medium trivial
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords: bibisected, bisected, difficultyBeginner, easyHack, implementationError, topicUI
Depends on:
Blocks: Chart-Wizard Tooltip
  Show dependency treegraph
 
Reported: 2023-10-18 09:33 UTC by Theppitak Karoonboonyanan
Modified: 2024-10-09 13:02 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Theppitak Karoonboonyanan 2023-10-18 09:33:11 UTC
In chart2/uiconfig/ui/steppedlinesdlg.ui, the extended tooltips for the following options are swapped:

- Step at the _horizontal mean
  (Start to step up vertically and end with horizontal line.)

- _End with horizontal line
  (Start with horizontal line, step up vertically in the middle of the X values
   and end with horizontal line.)
Comment 1 Stéphane Guillou (stragu) 2023-10-18 11:10:34 UTC
Thank you for catching that!

Confirmed that they are inverted in the UI in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e9374f74385d7dfe77d1902d3d82af20143bc775
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

And since they started being displayed in 7.1:

Version: 7.1.0.3 / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Started when extended tips were moved with commit f5c2c94fa7c896dc9a76c30d824cd1c3be725c65 (build commit 9c484baf80df7ef644a55ba4551ce59e7d6e634e in linux-64-7.1 bibisect repo).

(In reply to Theppitak Karoonboonyanan from comment #0)
> - Step at the _horizontal mean
>   (Start to step up vertically and end with horizontal line.)
https://opengrok.libreoffice.org/xref/core/chart2/uiconfig/ui/steppedlinesdlg.ui?r=95e986d6#157

> - _End with horizontal line
>   (Start with horizontal line, step up vertically in the middle of the X
> values
>    and end with horizontal line.)
https://opengrok.libreoffice.org/xref/core/chart2/uiconfig/ui/steppedlinesdlg.ui?r=95e986d6#177
Comment 2 Theppitak Karoonboonyanan 2024-10-08 16:25:26 UTC
Proposed gerrit commit:
https://gerrit.libreoffice.org/c/core/+/174700
Comment 3 Commit Notification 2024-10-09 13:02:58 UTC
Theppitak Karoonboonyanan committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0bf8a64f4104717c3584998f65b0d16c75df7a44

tdf#157811 Swap tooltips for stepped line types of line chart

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.