Bug 157882 - The arrowhead control in the sidebar line section is difficult to notice
Summary: The arrowhead control in the sidebar line section is difficult to notice
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.6.0.3 release
Hardware: All All
: medium minor
Assignee: Akshay Warrier
URL:
Whiteboard: target:24.8.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicUI
Depends on:
Blocks: Sidebar Shapes-Line
  Show dependency treegraph
 
Reported: 2023-10-21 20:00 UTC by Eyal Rozenberg
Modified: 2024-03-15 07:47 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (50.47 KB, image/png)
2023-10-23 08:13 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2023-10-21 20:00:58 UTC
In the Properties sidebar deck, Line section, the setting for start and end arrowheads:

* Has no label on its own
* Has no illustrative display unless already open; otherwise it has a "button" (and one that's flush with the surroundings unless focused)
* Precedes the line type control (solid/dotted/dashed/etc.)

It has happened to me in the past that I looked for it, and failed to find it - since I failed to notice there is anything other than line type control on that "row" of the Line section.

This should be improved. Arrowheads should have a "row" of their own, with a label of their own, and a preview of their own when the control isn't open. Also, I'd consider splitting it into a pair of such controls (can be on the same row).
Comment 1 Heiko Tietze 2023-10-23 08:13:33 UTC
Created attachment 190380 [details]
Screenshot

The sidebar must not replicate all UI elements from the dialogs. Adding a label, showing the current arrowheads, and splitting the input in start/end clutters the UI even more. My take, if the unlabeled item is so hard to understand, is to remove it from the sidebar.
Comment 2 Eyal Rozenberg 2023-10-23 10:59:56 UTC
(In reply to Heiko Tietze from comment #1)
> The sidebar must not replicate all UI elements from the dialogs.

I suppose that's a valid design choice, but - it's unreasonable to have Corner Style and Cap Style, but not start and end arrow choice - which are much much more frequently used.

Also, expanding the button into a preview still fits into the existing "row", if you wanted to skimp on real-estate.
Comment 3 Heiko Tietze 2023-10-23 11:46:06 UTC
(In reply to Eyal Rozenberg from comment #2)
> I suppose that's a valid design choice, but - it's unreasonable to have
> Corner Style and Cap Style...

Remove it all (the UI is way too busy).
Comment 4 Eyal Rozenberg 2023-10-23 11:57:57 UTC
(In reply to Heiko Tietze from comment #3)
> Remove it all (the UI is way too busy).

I... am ok with the current level of business, but this is not a strong opinion. Just saying that at the level we have now, the button is insufficient.
Comment 5 Heiko Tietze 2023-11-03 09:14:55 UTC
We discussed the topic in the design meeting.

First step could be to remove the cap/corner style controls and move the arrow head into an extra line with a label. In a follow-up patch we should split the arrow head control into beginning/end controls.

Code pointer: 
svx/uiconfig/ui/sidebarline.ui
(remove cornerlabel, edgestyle, caplabel, linecapstyle, add a label for arrow head and move the control there)

svx/source/sidebar/line/LinePropertyPanelBase.cxx
(remove all mxFTEdgeStyle, mxLBEdgeStyle, and ChangeEdgeStyleHdl and the same for the cap style; don't forget the header file)
Comment 6 Akshay Warrier 2024-01-20 14:18:40 UTC
I was looking a bit into this issue and it looks like the line properties ui is shared with chart2's line properties as well, so removing the cap/corner style controls from the ui file would also reflect in the chart's sidebar as well. Is that desirable?
Comment 7 Heiko Tietze 2024-01-22 09:48:02 UTC
The line cap style is hidden for chart lines. And I see no issue to have a consistent UI if there was a cap style.
Comment 8 Akshay Warrier 2024-01-22 09:59:31 UTC
The arrowhead control is hidden but corner and cap styles are present for chart. But either way, if you say having consistent UI is fine, then we should remove them from there as well.
Comment 9 Commit Notification 2024-02-20 19:54:51 UTC
AkshayWarrier committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8cd4cd31e9cffb593ccfba765fa28c2494a2d6f7

tdf#157882 svx: Remove cap/corner styles and move arrowhead control to new row

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.