Bug 158004 - Unify lockdown behavior of Options dialog page Connections
Summary: Unify lockdown behavior of Options dialog page Connections
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Balázs Varga (allotropia)
URL:
Whiteboard: target:24.2.0
Keywords:
Depends on:
Blocks: UI-Lockdown
  Show dependency treegraph
 
Reported: 2023-10-31 10:54 UTC by Gabor Kelemen (allotropia)
Modified: 2023-11-08 09:38 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Lock down extension for the Connections and Databases pages (1.65 KB, application/vnd.openofficeorg.extension)
2023-10-31 10:54 UTC, Gabor Kelemen (allotropia)
Details
The Connections page after installing the extension (110.45 KB, image/png)
2023-10-31 10:57 UTC, Gabor Kelemen (allotropia)
Details
The Databases page after installing the extension (79.42 KB, image/png)
2023-10-31 10:58 UTC, Gabor Kelemen (allotropia)
Details
modified extension to work on Windows (1.66 KB, application/vnd.openofficeorg.extension)
2023-11-06 11:42 UTC, Gabor Kelemen (allotropia)
Details
The Base - Databases tab after installing the second extension under Windows (21.01 KB, image/png)
2023-11-06 11:43 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2023-10-31 10:54:07 UTC
Created attachment 190543 [details]
Lock down extension for the Connections and Databases pages

When the settings of the Options dialog page Connections or Databases are locked down, several of the UI elements do not reflect this by becoming disabled and displaying a lock icon on their left.

1. Install the attached extension in the Tools - Extensions dialog
2. Restart LibreOffice
3. Go to Tools - Options - Base - Connections or Databases
-> the UI elements have no lock icon on their left, they are not disabled, changing their status and pressing OK usually crashes LibreOffice

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 3649dc202bedf72e37c77993a1f7027bfdfc6d9e
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded
Comment 1 Gabor Kelemen (allotropia) 2023-10-31 10:57:39 UTC
Created attachment 190544 [details]
The Connections page after installing the extension

Here only the first two items of the list are locked down, one enabled one disabled. Their settings are editable below the list, those should reflect the locked status.
Comment 2 Gabor Kelemen (allotropia) 2023-10-31 10:58:51 UTC
Created attachment 190545 [details]
The Databases page after installing the extension

Here the Addresses item is locked down, but the Delete and Edit buttons below the list are still enabled - those should be disabled.
Comment 3 Buovjaga 2023-10-31 17:11:10 UTC
Confirmed

Arch Linux 64-bit, X11
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c8da023efe26efcb166c3525ca73fe62f26e154c
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 31 October 2023
Comment 4 Gabor Kelemen (allotropia) 2023-11-06 11:42:12 UTC
Created attachment 190672 [details]
modified extension to work on Windows

This adds another path to the Base - Databases tab, one that shows up under Windows.
Comment 5 Gabor Kelemen (allotropia) 2023-11-06 11:43:35 UTC
Created attachment 190673 [details]
The Base - Databases tab after installing the second extension under Windows
Comment 6 Commit Notification 2023-11-07 20:41:37 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ebb51d094d9d58568ad6adf5730b04b5f24c7f25

tdf#158004 - UI: Part 20 - Unify lockdown behavior of Options dialog

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2023-11-08 09:38:38 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e0dd56acca39524b63b708590f03a3cd6dcbe3ca

Related: tdf#158004 - UI: Part 20 - Unify lockdown behavior of

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.