Bug 158017 - Impress Freshes Template using wrong font color in some slides
Summary: Impress Freshes Template using wrong font color in some slides
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Laurent Balland
URL:
Whiteboard: target:24.2.0
Keywords:
Depends on:
Blocks: Templates
  Show dependency treegraph
 
Reported: 2023-10-31 21:29 UTC by steve
Modified: 2023-12-05 09:57 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Impress > Freshes Templace > Slide 10 Screenshot 2023-10-31 wrong color (246.33 KB, image/png)
2023-10-31 21:29 UTC, steve
Details
Impress > Freshes Templace > Slide 10 Screenshot 2023-10-31 wrong color (249.43 KB, image/png)
2023-10-31 21:31 UTC, steve
Details
Screenshot page ten (191.00 KB, image/png)
2023-11-01 15:52 UTC, m_a_riosv
Details

Note You need to log in before you can comment on or make changes to this bug.
Description steve 2023-10-31 21:29:19 UTC
Description:
Freshes template uses wrong font color on some slides.

Steps to Reproduce:
1. Open Impress > Freshes Template
2. see that on e.g. Slide 3, 4 or 5 font color for text is "Dark Grey 1" (easy to check by opening "Format > Character…"
3. look at Slide 10 and 11 and see that the text uses black color 

Actual Results:
Text unreadable by default

Expected Results:
Text color on Slide 10 + 11 should follow design logic and concept of the rest of the Templace and also use Dark Grey 1.


Reproducible: Always


User Profile Reset: No

Additional Info:
View > Appearance > Dark
Application Colors > Custom Colors > Scheme: Automatic
Application Colors > Custom Colors > Automatic: System Theme

See attached screenshot

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b40e469887d973e1eea242749a90c3c2370da3a5
CPU threads: 8; OS: macOS 13.6.1; UI render: Skia/Raster; VCL: osx
Locale: en-US (en_DE.UTF-8); UI: en-US
Calc: threaded
Comment 1 steve 2023-10-31 21:29:44 UTC
Created attachment 190574 [details]
Impress > Freshes Templace > Slide 10 Screenshot 2023-10-31 wrong color
Comment 2 steve 2023-10-31 21:31:01 UTC
Created attachment 190575 [details]
Impress > Freshes Templace > Slide 10 Screenshot 2023-10-31 wrong color
Comment 3 m_a_riosv 2023-10-31 22:12:54 UTC
I can't see the issue with:
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7fff4e2ca6739928f72e5f0d2eb5820823916769
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded

Maybe you are using dark mode, or try disabling Skia
Comment 4 steve 2023-11-01 09:29:41 UTC
Using system dark mode in macOS.
Which font color where you seeing on that slide in your test?
Comment 5 m_a_riosv 2023-11-01 15:52:47 UTC
Created attachment 190586 [details]
Screenshot page ten
Comment 6 steve 2023-11-01 23:16:38 UTC
@m.a.riosv: Your screenshot shows identical problem as my screenshot but this bug here is still unconfirmed. What am I missing?
Comment 7 Heiko Tietze 2023-11-03 14:43:36 UTC
Is the font color in these boxes Automatic (which should be effectively white then) or black (which would be wrong)?
Comment 8 steve 2023-11-05 23:48:25 UTC
Currently: Font Color is black
Expected: Should be automatic (which will resolve this issue)

Curiously when I first tried to change the font color to Automatic, LO crashed 🙈, but the good news is, the crash is not reproducible.
Comment 9 Laurent Balland 2023-12-01 13:39:48 UTC
The font appears grey on white background because color is defined as black with 70% of transparency. See https://opengrok.libreoffice.org/xref/core/extras/source/templates/presnt/Freshes/content.xml?r=619500d6#642 for page 10
642     <style:style style:name="T16" style:family="text">
643       <style:text-properties fo:color="#000000" loext:opacity="30%" fo:font-size="14pt" style:font-size-asian="14pt" style:font-size-complex="14pt"/>
644     </style:style>

and https://opengrok.libreoffice.org/xref/core/extras/source/templates/presnt/Freshes/content.xml?r=619500d6#684 for page 11
684     <style:style style:name="T30" style:family="text">
685       <style:text-properties fo:color="#000000" loext:opacity="30%" style:font-name="Noto Sans1" fo:font-size="14pt" style:font-size-asian="14pt" style:font-size-complex="14pt"/>
686     </style:style>

I will check all places using fo:color="#000000"
 and replace with a grey color.
Comment 10 Laurent Balland 2023-12-01 13:42:18 UTC
There should be the same problem page 7?
Comment 11 Laurent Balland 2023-12-03 09:47:35 UTC
Patch expecting review:
https://gerrit.libreoffice.org/c/core/+/160238
Comment 12 Commit Notification 2023-12-04 17:51:51 UTC
Laurent Balland committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a56003dc89903f2b03d041807d48bb1e004a3853

tdf#158017 Freshes Impress template: color font

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 steve 2023-12-05 09:57:30 UTC
@Laurent: Thanks so much for tackling this issue here. Confirming text is now "Automatic" and displays as expected on page 7, 10 and 11. Nice to see such detail getting taken care of.

Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 1a74a87b442857567d20da5dc97bbbc278745afd
CPU threads: 8; OS: macOS 13.6.1; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_DE.UTF-8); UI: en-US
Calc: threaded