Bug 158041 - Drop unused Writer - Print config keys
Summary: Drop unused Writer - Print config keys
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Samuel Mehrbrodt (allotropia)
URL:
Whiteboard: target:24.8.0 inReleaseNotes:24.8
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup
Depends on:
Blocks: Dev-related
  Show dependency treegraph
 
Reported: 2023-11-02 13:13 UTC by Gabor Kelemen (allotropia)
Modified: 2024-06-03 17:11 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2023-11-02 13:13:17 UTC
It seems like from https://cgit.freedesktop.org/libreoffice/core/tree/sw/source/ui/config/optpage.cxx#n425 
SwAddPrinterTabPage::FillItemSet

that some configuration keys related to print settings in Writer are no longer in use, since 2010: https://cgit.freedesktop.org/libreoffice/core/log/?qt=grep&q=printerpullpages

These are:
Writer/Print/
  Content/
    Table
    Drawing
  Output
    SinglePrintJob
  Page
   Reversed

Code pointers:
sw/inc/printdata.hxx
sw/source/ui/config/optpage.cxx
sw/source/uibase/config/prtopt.cxx
officecfg/registry/schema/org/openoffice/Office/Writer.xcs
Comment 1 Xisco Faulí 2023-11-02 13:23:18 UTC
Turning this into an easyhack
Comment 2 Commit Notification 2023-12-18 06:48:17 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c9d5bf3fe0e6b59f30107c42eac3d4603bf8f2b6

[API CHANGE] tdf#158041 Remove unused SinglePrintJobs config option from sw

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2023-12-18 08:25:27 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a0782355c212b8237a6bfa3ce1c5bb010bd4caba

[API CHANGE] tdf#158041 Remove unused table printing option from sw

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2023-12-18 08:36:31 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6cdf523f179f3e7ed94267502a5fe3d1247398cc

[API CHANGE] tdf#158041 Remove unused drawing printing option from sw

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2023-12-18 12:22:55 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6dbc5e2bf4bd24c53ae3b906a5f74fb7ceed6ab9

[API CHANGE] tdf#158041 Remove unused reverse printing option from sw

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.