Description: I subscribed to LanguageTool Premium services with an email address containing the "+" character. It didn't work. When I switch to just using LanguageTool without any account (so without filling the form for user ID and token), it worked. So I thought about how many libraries out there does not implement the usage of the "+" character in email adresses and I change my ID user (which is also the email) to an email address which does not contain any "+", and it worked well. Steps to Reproduce: 1. use a "+" in our email address for subscribing to LanguageTool 2. try to use languagetool within LibreOffice 3. Actual Results: No correction Expected Results: Some correction Reproducible: Always User Profile Reset: No Additional Info: Yes, "+" is a valid character for email. You should be able to have something like: robert+di@caprio.com. the owner of robert@caprio.com should receive emails addressed to robert+whatever@caprio.com, see https://en.wikipedia.org/wiki/Email_address#Sub-addressing
Code pointer: makeHttpRequest in lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx It is likely that 'username' needs encoding before sending; it can be done using 'encodeTextForLanguageTool' there. Whoever decides to fix it, needs to get respective User ID, and test that it works. Not setting to NEW, because can't test myself.
Mike Kaganski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/05d5181e2c19aca7e6098217ddb7065e02819a53 tdf#158117: encode the username sent to LanguageTool It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/a57c8fdeb21f4ee77763833a3c92ea337a649cda tdf#158117: encode the username sent to LanguageTool It will be available in 7.6.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
@https://buildnowgg.co/ You can go to Tools > Options > Language Settings > Writing Aids. Then, uncheck the box for LanguageTool, click OK, and then re-enable it.
*** Bug 159551 has been marked as a duplicate of this bug. ***