Bug 158248 - Ability to add to any folder in the Gallery by dragging into it
Summary: Ability to add to any folder in the Gallery by dragging into it
Status: UNCONFIRMED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Gallery Shapes Drag-and-Drop
  Show dependency treegraph
 
Reported: 2023-11-16 18:41 UTC by Eyal Rozenberg
Modified: 2023-12-02 21:00 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2023-11-16 18:41:00 UTC
In Impress, we have selections of shapes available either as toolbar buttons, buttons in toolbar menu-buttons/dialog-buttons, or in the shapes sidebar. However - we cannot add new shapes to any of these.

I expect to be able to take an object I have in my document, and add it to the set of shapes I can then create. Intuitively, dragging - or perhaps dragging with some control-key combination - should let me do that, or at least get a dialog offering me to do that.

The strongest of these request regards the shapes sidebar - which is kind of a special sidebar anyway, unlike toolbars that are (?) the same for all modules.

IIRC, this is something one can do with MS Visio Stencils.
Comment 1 m_a_riosv 2023-11-16 21:37:23 UTC
If I'm not wrong, it can be done with the Gallery

https://help.libreoffice.org/latest/en-US/text/shared/guide/dragdrop_gallery.html?DbPAR=SHARED#bm_id3154927
Comment 2 Eyal Rozenberg 2023-11-16 22:01:17 UTC
(In reply to m.a.riosv from comment #1)
> If I'm not wrong, it can be done with the Gallery

Isn't the gallery just for rectangular objects with no control capabilities?

... hey, it isn't! Weird. Why do we have a Shapes sidebar if we also have shapes in the gallery? Just because the gallery items have auto-generated icons rather than custom ones? That seems a bit silly.

Anyway, the instructions at the link don't work. Following them does not add a shape to the Gallery.
Comment 3 Eyal Rozenberg 2023-11-16 22:04:15 UTC
So, I've noticed there's a 1:1 correspondence between Shapes sidebar categories and the toolbar button-dialogs with shapes. So, adding to the Shapes sidebar should suffice for (almost) everything.

However... maybe I should split this bug into:

1. Ability to add - in any way - to the Shapes sidebar, and
2. Ability to drag onto the Shapes sidebar

since we don't seem to have (1.) either.
Comment 4 nutka 2023-11-17 21:08:13 UTC
(In reply to Eyal Rozenberg from comment #2)
>
> Anyway, the instructions at the link don't work. Following them does not add
> a shape to the Gallery.
May I ask what's stopping you from adding a shape to the Gallery?
The description given at the link is almost precise.
The part on employing the Alt key seems faulty.
Comment 5 Eyal Rozenberg 2023-11-17 22:13:01 UTC
(In reply to nutka from comment #4)
> May I ask what's stopping you from adding a shape to the Gallery?
> The description given at the link is almost precise.

When I drag the selected item onto the Gallery, an item is not added.

> The part on employing the Alt key seems faulty.

That's for hyperlinks...
Comment 6 nutka 2023-11-17 22:28:48 UTC
I can add the selected item into Gallery only in a new theme
(that's why I wrote: "the description given at the link is almost precise").

Of course, the Alt key is for hyperlinks. I just noticed that it doesn't work with the Alt key.
Comment 7 Stéphane Guillou (stragu) 2023-11-30 19:53:26 UTC
(In reply to Eyal Rozenberg from comment #5)
> When I drag the selected item onto the Gallery, an item is not added.
1. Create a new folder for the gallery, with the "New..." button
2. When drag-and-dropping, make sure you wait a second before moving so the cursor changes. This is the same kind of interaction as when moving an object to another layer.

In my opinion, the Gallery should be preferred for your use case. It's the place that's already flexible enough to create any number of collections containing various kinds of objects.
But adding to the gallery should be made easier - I'm not even sure it's possible to do it without the mouse.
And the documentation should be improved.
Comment 8 Heiko Tietze 2023-12-01 13:52:57 UTC
Shipped content resides in protected space, eg. /lib/libreoffice/share/gallery/ on Linux. You can only change content in ~/.config/libreoffice/4/user/gallery/. Either we move all Galleries into extensions (would be a duplicate of bug 131529) or accept the read-only fact - and mark it somehow.
Comment 9 Eyal Rozenberg 2023-12-01 15:46:27 UTC
So, let's focus on the gallery in this bug and forget about the Shapes sidebar for the time being, since that's what commenters have done and these are two different, though somewhat related, issues.


(In reply to Stéphane Guillou (stragu) from comment #7)
> 1. Create a new folder for the gallery, with the "New..." button

No, no, not doing that. I can't put something in "Shapes"? In "Icons"? That's preposterous.

> But adding to the gallery should be made easier

Let's start with making it possible. Although TBH, the more I think about it, the less I'm a fan of even having the gallery at all. It seems more like an excuse not to work on other things than an actual feature people use.
Comment 10 Eyal Rozenberg 2023-12-01 15:50:33 UTC
(In reply to Heiko Tietze from comment #8)
> Shipped content resides in protected space, eg.
> /lib/libreoffice/share/gallery/ on Linux. You can only change content in
> ~/.config/libreoffice/4/user/gallery/. Either we move all Galleries into
> extensions (would be a duplicate of bug 131529) or accept the read-only fact
> - and mark it somehow.

I don't know that I support bug 131529. Why should every user get a copy of all of that clipart? Doesn't make much sense to me. 

And of course, we cannot "accept the read-only fact". It's a bug. The details of how the gallery is implemented and where files are stored is the application's problem, not the user. The user should be able to add shapes, and the app should figure out how to combine the fixed shared set of shapes with the user's.
Comment 11 Heiko Tietze 2023-12-01 15:53:40 UTC
(In reply to Eyal Rozenberg from comment #10)
> Why should every user get a copy of all of that clipart?
You do get a copy anyway but at read-only /lib... and not ~/.config. You request the same as in bug 131529 => DUP

*** This bug has been marked as a duplicate of bug 131529 ***
Comment 12 Eyal Rozenberg 2023-12-01 15:56:24 UTC
(In reply to Heiko Tietze from comment #11)
> You request the same as in bug 131529 => DUP

No, I didn't => Not a dupe.

I don't request the galleries to be an extension, nor to have a copy of the gallery for each user. In fact, I'm against the latter and am not sure about the former.
Comment 13 Stéphane Guillou (stragu) 2023-12-01 16:22:29 UTC
To be clear:
* It _is_ possible to drag-and-drop into the gallery, but only into folders you created with the "New" button (there's a different coloured icon for editable ones).
* If you want the default folders to be editable, that's what bug 131529 is already asking for.

So what exactly is the difference with this ticket?
Comment 14 Eyal Rozenberg 2023-12-01 18:39:01 UTC
(In reply to Stéphane Guillou (stragu) from comment #13)
> To be clear:
> * It _is_ possible to drag-and-drop into the gallery, but only into folders
> you created with the "New" button (there's a different coloured icon for
> editable ones).

So, it generally isn't possible. But - I'll qualify the title.

> * If you want the default folders to be editable, that's what bug 131529 is
> already asking for.

That bug is asking to "Install galleries in the user space" (that is its title). I don't want that.
Comment 15 V Stuart Foote 2023-12-01 19:24:08 UTC
-1, our OOo legacy has been for a RO library of content installed to $ORIGIN.

Users have always been able to append as noted comment 7, and that is held in users personal space.

As built and installed paths are distinct. We need that for application stability, with plenty of opportunity for users to customize (to private space and to program $ORIGIN if they have os/fs permissions to do so) and for extension authors to deliver fully scoped clipart/draw objects and graphics to the SB Gallery.
Comment 16 Eyal Rozenberg 2023-12-01 20:08:23 UTC
(In reply to V Stuart Foote from comment #15)
> Users have always been able to append as noted comment 7, and that is held
> in users personal space.

Perhaps you mean to say that users have never been able to append intuitively, and we've not had many complaints because few, if any, people use the gallery?

> As built and installed paths are distinct. 

Not sure I understand what you mean. 


Let's just have the added items be placed in ~/.config/libreoffice/4/user/gallery/  , and display the union of that and the global gallery. Like Start Menu entries in Windows which can be either global or local.
Comment 17 V Stuart Foote 2023-12-01 20:34:26 UTC
(In reply to Eyal Rozenberg from comment #16)
> (In reply to V Stuart Foote from comment #15)
> > Users have always been able to append as noted comment 7, and that is held
> > in users personal space.
> 
> Perhaps you mean to say that users have never been able to append
> intuitively, and we've not had many complaints because few, if any, people
> use the gallery?
> 

Nope ;-)

> > As built and installed paths are distinct. 
> 
> Not sure I understand what you mean. 
> 

Open Tools -> Options -> Paths; the Internal Paths are RO, the User Paths are fully editable. Where appropriate in the UI, they *already are* merged, i.e. the SB Gallery deck by groupings. User items will go into user profile in discrete groupings (named as you like) and won't mix with the other RO groupings on Internal Paths by UI actions.

While via Extension and for sysadmins with os/fs permissions can modify/delete existing gallery items on the RO Internal Paths--questionable requirement for users to be able to via UI.
Comment 18 Eyal Rozenberg 2023-12-02 21:00:44 UTC
(In reply to V Stuart Foote from comment #17)
> While via Extension and for sysadmins with os/fs permissions can
> modify/delete existing gallery items on the RO Internal Paths--questionable
> requirement for users to be able to via UI.

Deletions are a different bug: 158479

But for both additions and deletions - they can be user-specific, with the user never changing anything in the system paths, just under their own path. No need for special permissions.