Bug 158280 - Replace usage of InputDialog with SvxNameDialog
Summary: Replace usage of InputDialog with SvxNameDialog
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:25.8.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup, topicUI
Depends on:
Blocks: Dev-related
  Show dependency treegraph
 
Reported: 2023-11-20 09:12 UTC by Samuel Mehrbrodt (allotropia)
Modified: 2025-05-15 11:10 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Mehrbrodt (allotropia) 2023-11-20 09:12:10 UTC
InputDialog (include/sfx2/inputdialog.hxx) serves the same purpose as SvxNameDialog (include/cui/dlgname.hxx).

Usage of InputDialog should be replaced with SvxNameDialog.

When all uses are removed, InputDialog can be dropped too.
Comment 1 Sakura286 2024-10-24 03:24:21 UTC
There is only `inputdlg.hxx` but no `inputdialog.hxx` in `include/sfx2`.
Comment 2 Samuel Mehrbrodt (allotropia) 2024-10-28 14:08:22 UTC
(In reply to Sakura286 from comment #1)
> There is only `inputdlg.hxx` but no `inputdialog.hxx` in `include/sfx2`.

Ah it's include/sfx2/inputdlg.hxx

See https://opengrok.libreoffice.org/search?project=core&full=&defs=&refs=InputDialog
Comment 3 Ujjawal Kumar 2025-01-20 14:29:20 UTC
Hey I've released a patch here: https://gerrit.libreoffice.org/c/core/+/180514

Can you please let me know if I am headed in the right direction. Thanks!
Comment 4 Commit Notification 2025-01-24 18:18:41 UTC
bruh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a88b3da5b01403ba593423821843a0dacda158ec

tdf#158280 Replace usage of InputDialog with SvxNameDialog

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2025-01-24 21:42:03 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b9fd8cc18a9cd5cd4ae86b4256cf8786ea34ea89

Revert "tdf#158280 Replace usage of InputDialog with SvxNameDialog"

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2025-02-03 06:39:12 UTC
bruh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cda4965ea65ff9fa0e63e53344f46aeac91848a9

tdf#158280 Replace usage of InputDialog with SvxNameDialog

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2025-05-15 11:10:17 UTC
Sebastian Neagu committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2aedb4ae1fe3efe18920a01940bad1bb014265a5

tdf#158280 Replace usage of InputDialog with SvxNameDialog

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.