Bug 158280 - Replace usage of InputDialog with SvxNameDialog
Summary: Replace usage of InputDialog with SvxNameDialog
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:25.8.0 target:26.8.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicCleanup, topicUI
Depends on:
Blocks: Dev-related
  Show dependency treegraph
 
Reported: 2023-11-20 09:12 UTC by Samuel Mehrbrodt
Modified: 2026-02-20 07:18 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Mehrbrodt 2023-11-20 09:12:10 UTC
InputDialog (include/sfx2/inputdialog.hxx) serves the same purpose as SvxNameDialog (include/cui/dlgname.hxx).

Usage of InputDialog should be replaced with SvxNameDialog.

When all uses are removed, InputDialog can be dropped too.
Comment 1 Sakura286 2024-10-24 03:24:21 UTC
There is only `inputdlg.hxx` but no `inputdialog.hxx` in `include/sfx2`.
Comment 2 Samuel Mehrbrodt 2024-10-28 14:08:22 UTC
(In reply to Sakura286 from comment #1)
> There is only `inputdlg.hxx` but no `inputdialog.hxx` in `include/sfx2`.

Ah it's include/sfx2/inputdlg.hxx

See https://opengrok.libreoffice.org/search?project=core&full=&defs=&refs=InputDialog
Comment 3 Ujjawal Kumar 2025-01-20 14:29:20 UTC
Hey I've released a patch here: https://gerrit.libreoffice.org/c/core/+/180514

Can you please let me know if I am headed in the right direction. Thanks!
Comment 4 Commit Notification 2025-01-24 18:18:41 UTC
bruh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a88b3da5b01403ba593423821843a0dacda158ec

tdf#158280 Replace usage of InputDialog with SvxNameDialog

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2025-01-24 21:42:03 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b9fd8cc18a9cd5cd4ae86b4256cf8786ea34ea89

Revert "tdf#158280 Replace usage of InputDialog with SvxNameDialog"

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2025-02-03 06:39:12 UTC
bruh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cda4965ea65ff9fa0e63e53344f46aeac91848a9

tdf#158280 Replace usage of InputDialog with SvxNameDialog

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2025-05-15 11:10:17 UTC
Sebastian Neagu committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2aedb4ae1fe3efe18920a01940bad1bb014265a5

tdf#158280 Replace usage of InputDialog with SvxNameDialog

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 viraj 2026-02-07 09:09:02 UTC
Proposed a patch for review at:
https://gerrit.libreoffice.org/c/core/+/198880
Comment 9 Commit Notification 2026-02-17 16:42:05 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7c42839f7b4a26d1f239a5f1968b65295f9c4117

tdf#158280 Move SvxNameDialog etc. from cui to svtools

It will be available in 26.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2026-02-17 16:43:08 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f89f83e64529f0241d5f6e9aea1c6e6f7ebcf706

tdf#158280 Use SvxNameDialog directly in SvxColorTabPage

It will be available in 26.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2026-02-18 15:43:34 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ed50960724fa6fa5ed1106783ffcd175c5298d76

tdf#158280 Use SvxNameDialog directly in AccessibilityIssue

It will be available in 26.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2026-02-19 13:29:15 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6ff279c67dd45b801a120f876da5a590e18bf442

tdf#158280 Use SvxNameDialog directly in SvxGradientTabPage

It will be available in 26.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2026-02-19 13:30:18 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/42d3036dc4d1231b7464e62a64845bc332aa227a

tdf#158280 Use SvxNameDialog directly in SvxLineEndDefTabPage

It will be available in 26.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Commit Notification 2026-02-19 13:30:20 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/863479b367fd815363ef887fcaa7737ba0a5b973

tdf#158280 Use SvxNameDialog directly in FuLineEnd::DoExecute

It will be available in 26.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Commit Notification 2026-02-19 13:30:23 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3f967c4d1dcd04b00efdc070430ad25bfae7b2ff

tdf#158280 sd: Use SvxNameDialog directly in SlotManager

It will be available in 26.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Commit Notification 2026-02-19 13:30:25 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f5293f1095a712324b7e911a256bbfeba63c673d

tdf#158280 sd: Use SvxNameDialog directly in DrawViewShell

It will be available in 26.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Commit Notification 2026-02-19 13:30:28 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f52f784a9ea3e5ca61453998318f0151cf7f6e4c

tdf#158280 sd: Use SvxNameDialog directly in View::GetExchangeList

It will be available in 26.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Commit Notification 2026-02-19 13:30:31 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a799b6755cc0c06f25bd016e0610485938071c7b

tdf#158280 starmath: Use SvxNameDialog directly in SmViewShell

It will be available in 26.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Commit Notification 2026-02-20 07:18:31 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d2d466e851452375b20a4da8b6a76ec5b80d597f

tdf#158280 cui: Use SvxNameDialog directly in TSAURLsDialog

It will be available in 26.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 20 Commit Notification 2026-02-20 07:18:33 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/72c7fb6f0444110085dda39e38d8b468b4680158

tdf#158280 cui: Use SvxNameDialog directly in SvxBitmapTabPage

It will be available in 26.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 21 Commit Notification 2026-02-20 07:18:36 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cd916775d7b031404261b9ae2f90d496f18b5aaf

tdf#158280 cui: Use SvxNameDialog directly in SvxHatchTabPage

It will be available in 26.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 22 Commit Notification 2026-02-20 07:18:39 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/92b6cd53daa6f4dac17f282d3f7709dbdcf8ffef

tdf#158280 cui: Use SvxNameDialog directly in SvxLineDefTabPage

It will be available in 26.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 23 Commit Notification 2026-02-20 07:18:41 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/41fba33c48a2b0d031786f92b1aa82a736cbf646

tdf#158280 cui: Use SvxNameDialog directly in SvxPatternTabPage

It will be available in 26.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 24 Commit Notification 2026-02-20 07:18:44 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/706bdb9eca55b3e48b78a60f68114794e28c57fc

tdf#158280 sd: Use SvxNameDialog directly in DrawDocShell

It will be available in 26.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.