Bug 158357 - UI simplify Hyperlink dialog by removing Hyperlink type radiobutton
Summary: UI simplify Hyperlink dialog by removing Hyperlink type radiobutton
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha1+
Hardware: All All
: medium trivial
Assignee: Julien Nabet
URL:
Whiteboard: target:24.2.0
Keywords:
Depends on:
Blocks: Hyperlink-Dialog
  Show dependency treegraph
 
Reported: 2023-11-24 14:37 UTC by Gabor Kelemen (allotropia)
Modified: 2023-11-25 17:10 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
Screenshot of the dialog in recent master (30.66 KB, image/png)
2023-11-24 14:37 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2023-11-24 14:37:46 UTC
Created attachment 191021 [details]
Screenshot of the dialog in recent master

After the FTP type hyperlink support was removed from the Hyperlink dialog in bug 146386, there is now a single Web radio button, which makes no sense to have.

1. In Writer go to Insert - Hyperlink
-> dialog has a single Protocol: Web radio button

This can be removed at this point, and whatever settings/behaviors depended on it under the hood just made default.
The "Hyperlink Type" heading also could be renamed to "Hyperlink Settings" to make more sense.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: a91892ec4942fc875820ea02dfbe74e986548142
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded
Comment 1 Julien Nabet 2023-11-25 09:00:53 UTC
I gave a try here:
https://gerrit.libreoffice.org/c/core/+/159947

As indicated in commit message, I also removed "Protocol:" since it's also useless now.

I wonder if the blank space at the middle is useful.
Comment 2 Commit Notification 2023-11-25 11:09:15 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8b50a615cbf6c09ed9cf6af6336e388cd32db28e

tdf#158357: UI simplify Hyperlink dialog by removing Hyperlink type radiobutton

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.