Bug 158545 - UI: Original size button in image properties -> position and size tab doesn't restore original size for paper size exceeding images in Writer (and breaks image ratio)
Summary: UI: Original size button in image properties -> position and size tab doesn't...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Image-Dialog
  Show dependency treegraph
 
Reported: 2023-12-05 14:28 UTC by Telesto
Modified: 2024-01-12 10:39 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Image sample (389.66 KB, image/jpeg)
2024-01-03 13:54 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2023-12-05 14:28:06 UTC
Description:
UI: Original size button in image properties -> position and size tab doesn't restore original size in Writer (and breaks image ratio)

Steps to Reproduce:
1. Open attachment 173542 [details]
2. Select Camera image
3. Press F4
4. Go to crop tab. Notice original dimensions being 28,22 cm by 21,17 cm
5. Press Original size and press OK -> Skewed image
7. Press CTRL+Z
8. Go to Position and Size tab. 
9. Press Original size and press OK -> Skewed image

No exceeding the paper dimensions might be valid reason. However 
(a) can you call it 'Original size'? 
(b) if image size should be reduced: keeping the image ratio seems normal expectation. 

Actual Results:
* Original size isn't original size
* Image ratio is broken. FWIW: I tend to press Original size when I want to restore original image ratio properties.
 

Expected Results:
* Keep image ratio when 'original size' isn't allow?
* Rephrase 'original size'... but I have no idea how it should be called..
* Add button restore original image ratio?


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ff3fb42b48c70ba5788507a6177bf0a9f3b50fdb
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 1 Dieter 2023-12-23 18:41:55 UTC
I cinfirmed the described behaviour with

Version: 24.2.0.0.beta1 (X86_64) / LibreOffice Community
Build ID: 5f390384195b7264c6e52add9e90a39790285249
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded

Additional observation:
Values in Scale are wrong after pressing "origional size" button, because they are not in line with Image size and the result.

would call it enhancemnt (of the dialog) request
Adding design-team for further ideas
Comment 2 Heiko Tietze 2024-01-02 14:23:42 UTC
Agree, the ratio should be kept. But what could be an alternative label for the original size?
Comment 3 Eyal Rozenberg 2024-01-02 19:18:53 UTC
I would have liked to say that original size should really mean the original size; but - at the moment, it seems Writer forbids exceeding page dimensions, so that might be impossible. Anyway, "original size" the way it is now must be either rephrased or removed.


At any rate, buttons which _might_ be relevant for me:

* scale proportionally as much as possible within the page
* scale proportionally as much as possible within the page while maintaining some position, e.g. image center, or one of the corners etc.
* scale proportionally towards the original dimensions, as much as a the page allows
* scale to page dimensions
* scale until hitting a page boundary, while maintaining some position, e.g. image center, or one of the corners etc.
* scale to the minimum of the original dimension and the page dimension on each axis

not sure which are more important than which.
Comment 4 Heiko Tietze 2024-01-03 09:42:27 UTC
Miklos, Mike: any insights why Writer prevents to exceed the page size?
Comment 5 Telesto 2024-01-03 13:54:44 UTC
Created attachment 191729 [details]
Image sample

(In reply to Heiko Tietze from comment #2)
> Agree, the ratio should be kept. But what could be an alternative label for
> the original size?

Maybe something like: Reset dimensions. Which acts at fit to page (proportional) for large image dimensions; in other cases the embedded dimensions are used

(In reply to Heiko Tietze from comment #4)
> Miklos, Mike: any insights why Writer prevents to exceed the page size?

Well not directed to me... but for the record: I surely don't want to be inserted or reset to actual dimensions. Images are often stored at 72 dpi with 16 megapixels or more. Result: insanely large images dimensions (based on DPI). The 'original size' button shouldn't do this either, IMHO. It's not useful/sensible/practical, if you ask me 

Draw example
1. Insert the attached image into draw (image shrinks to page on insertion; fine)
2. You can increase the size by stretching it with the corners of the image (page size is not a hard limit in Draw, it is in Writer: annoying)
3. Right click the image -> Select Original size (unpractical end-result)

So insertion: fit to page (proportionally) for large images, in other cases else embedded size (across the board; Writer, Impress, Draw, Calc)

The Writer page size shouldn't be hard limit, ideally. However the current behaviour isn't to problematic. My primary concerns: (a) Images losing proportions (b) the label not matching what it actually does in case of Writer.
Comment 6 Miklos Vajna 2024-01-04 07:34:08 UTC
(In reply to Heiko Tietze from comment #4)
> Miklos, Mike: any insights why Writer prevents to exceed the page size?

One reason my be consistency. Writer defaults to capturing drawing objects inside the page frame. sw/source/core/doc/DocumentSettingManager.cxx:76 has a compat setting named DoNotCaptureDrawObjsOnPage to decide if we want this capturing or not, capturing is on by default.
Comment 7 Cor Nouws 2024-01-11 11:21:25 UTC
(In reply to Telesto from comment #5)

> Maybe something like: Reset dimensions. Which acts at fit to page
> (proportional) for large image dimensions; in other cases the embedded
> dimensions are used
Sounds good to me.

> The Writer page size shouldn't be hard limit, ideally ...
It is expected that the behavior origins from the time that a text editor was exclusively linked to printing documents on some standard sized paper ;)

I find myself seldom in a situation where it causes extra work (cropping images).
Comment 8 Heiko Tietze 2024-01-12 10:39:27 UTC
We discussed the topic in the design meeting.

MSO365 allows scaling beyond the page size and cuts off the extra part (moving out of the canvas is not possible, however). This would be the preferred solution.

Until then we suggest to rename the function into "Reset" and add a tooltip with "Resets width and height to the original size, unless limited by the page size". Furthermore the original dimension like shown in the compress dialog before this button should make clear what is being reset here.

In any case the aspect ratio should be kept.