A backport to LO 7.6.4 caused an RTF file to lose its first page break. Steps to reproduce. -open attachment 191090 [details] (A011-min-cleaned.rtf) -it should be two pages long - with the first page being empty.
I identified, using 7.6 bibisect, commit f24ad883b15a8112d7dfeb4de14afaf67da30a47 Author: Michael Stahl on Thu Nov 9 19:54:19 2023 +0100 tdf#153178 writerfilter: do not create text frame spuriously Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159228
confirmed the specified commit using bibisect 24.2.
It is somehow related to the headers/footers. If I remove all of them from the RTF, then the page break remains.
Indeed, the document should be 2 pages, but now it's only one.
The difference comes because RTFFrame::setSprm if (m_pDocumentImpl->getFirstRun() && !m_pDocumentImpl->isStyleSheetImport()) { m_pDocumentImpl->checkFirstRun(); // This in particular m_pDocumentImpl->setNeedPar(false); }
proposed fix at https://gerrit.libreoffice.org/c/core/+/160655
My fix works at the point of regression, but it breaks again later in 7.6.4. commit 15b886f460919ea3dce425a621dc017c2992a96b Author: Michael Stahl on Fri Nov 10 17:04:27 2023 +0100 tdf#153194 writerfilter: RTF import: \spltpgpar
Created attachment 191463 [details] A011-min-cleanedNeedPar.rtf: seems fixed by my patches - worth keeping an eye on
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/798649ec30b536614048aa457fb9c8d4dce30b31 tdf#158583 tdf#158586 RTF writerfilter: only startRun for real frame It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e915d9f6973c742a1d810c460d895a93522d3308 related tdf#158586 RTF writerfilter: HAnchor's default is text, not margin It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/016f779ee6c7f601be3ae19dc57497e63a5bf817 tdf#158586 RTF writerfilter: substitute hasProperties for inFrame It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/465cc1bbbe86b2affc112c6be79c7c0e9ea885e6 tdf#158583 tdf#158586 RTF writerfilter: only startRun for real frame It will be available in 24.2.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/b5758c9e69e8c4c7a0f638345b21b876bd503ac3 related tdf#158586 RTF writerfilter: HAnchor's default is text, not margin It will be available in 24.2.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/7abb319821e641599f92e5f4ad2d7c0e377851fa tdf#158586 RTF writerfilter: substitute hasProperties for inFrame It will be available in 24.2.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/ee4a371e7cd6029978260b7692fe5b5db00dce8b tdf#158583 tdf#158586 RTF writerfilter: only startRun for real frame It will be available in 7.6.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
This bug is NOT YET FIXED. I have a work-in-progress patch, but it might not be the best. https://gerrit.libreoffice.org/c/core/+/160745
Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/57abad5cf990111fd7de011809d4421dc0550193 tdf#158586 writerfilter: RTF import: fix \page \sect \skbnone It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/dbe78489e98d565b72a703524308523135ffdd67 tdf#158586 writerfilter: RTF import: handle \sect in frame as \par It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/17e2c7226a73675d69febf0915aaeae61ad8e9f1 tdf#158586 writerfilter: RTF import: fix \page \sect \skbnone w/ header It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
fixed on master thanks Justin for finding these issues and the frame related fixes
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/e63a75e00dcd797b0bd061add3c72dcb7b353007 tdf#158586 writerfilter: RTF import: fix \page \sect \skbnone It will be available in 7.6.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/0d66c56d48476efdf8d9d9d9549f59cdad5cb25d tdf#158586 writerfilter: RTF import: handle \sect in frame as \par It will be available in 7.6.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/ae3f45e39b59583a60a751dcb54889f1ee28197b tdf#158586 writerfilter: RTF import: fix \page \sect \skbnone w/ header It will be available in 7.6.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/6dde3695c27b28165b5aa27de5a6e309b860e02f tdf#158586 writerfilter: RTF import: fix \page \sect \skbnone It will be available in 24.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/d5e2e66f8eb7cb89863ee0096f0569d2358fa1b7 tdf#158586 writerfilter: RTF import: handle \sect in frame as \par It will be available in 24.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/0a53b7f64dddc31b705080bb21230aae99212062 tdf#158586 writerfilter: RTF import: fix \page \sect \skbnone w/ header It will be available in 24.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6446d3e12440be39e6b55f8749038061a1b240da tdf#158586 writerfilter: RTF import: fix assert on ooo113308-1.rtf It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/e85453e5319d5072a49ba6749fabdc804eaf64e8 tdf#158586 writerfilter: RTF import: fix assert on ooo113308-1.rtf It will be available in 7.6.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/59aca5a45b1bd5a3f9261ae12b9723ef89edde58 tdf#158586 writerfilter: RTF import: fix assert on ooo113308-1.rtf It will be available in 24.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/188caca7dec0251597bd2ea40448de752b3fd1a1 tdf#158586 RTF writerfilter: substitute hasProperties for inFrame It will be available in 7.6.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
*** Bug 152885 has been marked as a duplicate of this bug. ***