Bug 158598 - Command "Show Comment" should be available in the Tabbed UI
Summary: Command "Show Comment" should be available in the Tabbed UI
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.6.0.3 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Calc-Comments Notebookbar-Tabbed
  Show dependency treegraph
 
Reported: 2023-12-08 15:20 UTC by Rafael Lima
Modified: 2024-04-29 04:26 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2023-12-08 15:20:22 UTC
In Calc using the Tabbed UI, the command "Show Comment" is not available in the Review tab.

I came across this issue while trying to show a single comment using the Tabbed UI and it was not possible.

I believe the "Show Comment" command could be placed right below the "Edit Comment" command.
Comment 1 ady 2023-12-08 18:22:32 UTC
(In reply to Rafael Lima from comment #0)
> trying to show a single comment 

For one comment, why not just right-click on the cell and then click on Show Comment?

That is for a permanent display of the comment, of course. We can still hoover over the cell in order to show the comment temporarily as a tooltip.

In order to show _all_ comments, there is menu View > Comments.

Having said that, using the Tabbed UI on MS Windows, within the Review tab there are:

* Comment (to insert a new comment)
* Edit Comment (which would also show it temporarily)
* Show All Comments
* Hide All Comments
(In case the request of this report is implemented, then there should also be a toggle Show/Hide All Comments, and then these 2 new ones can take the default place of the above 2 icons, leaving them as a customization)

* Delete All Comments
* Delete Comment


IMHO, using right-click in order to permanently show one comment seems enough for most users, even if you have to repeat the action more than once. If you have to repeat the action frequently, customizing a direct keyboard shortcut is also an option, or using "Show All Comments" first and then hiding those that should not be displayed permanently would also be an alternative.

I'm not opposing the implementation (+ adding also a "Show/Hide All Comments" options). I'm just mentioning the currently available alternatives.
Comment 2 Heiko Tietze 2024-01-05 12:41:10 UTC
Rafael, can you agree with Ady's arguments, which I read as "no need to implement"? Too many commands clutter the UI and we should add only the absolut necessary.
Comment 3 ady 2024-01-05 21:33:16 UTC
(In reply to Heiko Tietze from comment #2)
> Rafael, can you agree with Ady's arguments, which I read as "no need to
> implement"? Too many commands clutter the UI and we should add only the
> absolut necessary.

The middle ground would be to allow the icon/function (and the additional Show/Hide All Comments toogle one I mentioned too), but have it disabled by default. IOW, allow it to be available for users customizing the NotebookBar UI.
Comment 4 Heiko Tietze 2024-01-08 09:17:06 UTC
(In reply to ady from comment #3)
> ...have it disabled by default.
Would be a large button then, I guess. 

The Notebookbar has Comment (actually Add only, disabled when the cell has a comment), Edit Comment (always available), two buttons for Show/Hide All Comments, and two for Delete (one)/All Comments. We could remove the Add button (ideally change the label Edit into Add if the cell has no comment), turn Show/Hide into a toggle (IIRC there is such a command), add Show (one) Comment underneath, and keep the delete functions.

I still struggle with the workflow. In particular with the Tabbed UI it needs one click at the Review tab, one at the Show button and one again to hide it. If you really need to toggle it on/off wouldn't that rather be solved by a shortcut? Works out of the box with ctrl+alt+C but a simple show could be assigned to F3, for instance.
Comment 5 Rafael Lima 2024-01-08 18:56:13 UTC
(In reply to ady from comment #1)
> For one comment, why not just right-click on the cell and then click on Show
> Comment?

Indeed this is the current way to execute the "Show Comment" command.

However, for those using the Tabbed UI, it would be handy to have the command there as well.

Since we have a Review tab, as a user I would expect to find the "Show/Hide Comment" command there somewhere.

(In reply to Heiko Tietze from comment #4)
> We could remove the Add
> button (ideally change the label Edit into Add if the cell has no comment),
> turn Show/Hide into a toggle (IIRC there is such a command), add Show (one)
> Comment underneath, and keep the delete functions.

The Add/Edit idea sounds good. This is what happens when you right-click a cell. If it does not have comments, then "Insert Comment" appears in the popup menu. If it has a comment, then "Edit Comment" is enabled.

Also, the idea of Show/Hide comment being a toggle sounds nice. It's more intuitive IMO.
Comment 6 Heiko Tietze 2024-01-10 12:28:28 UTC
Adding items to the Notebookbar is an easyhack but not changing the command into a toggle, or at least it requires a bit coding expertise.
Comment 7 Stéphane Guillou (stragu) 2024-04-29 04:17:11 UTC
See also discussion in bug 133539, suggesting grouping commands under dropdowns.