Bug 158631 - Simplify storing of the "Print mode" setting in Impress/Draw settings
Summary: Simplify storing of the "Print mode" setting in Impress/Draw settings
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Print Options-Dialog-Expert
  Show dependency treegraph
 
Reported: 2023-12-10 21:16 UTC by Gabor Kelemen (allotropia)
Modified: 2023-12-29 23:44 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2023-12-10 21:16:18 UTC
This is a followup to bug 158240 / bug 158245 (this affects both Impress/Draw)

It was noticed that there is under Page Options three mutually exclusive settings: Fit to page, Tile page and Brocure, plus the Default indicating that none of these is set (by default, they are all false).

All three settings are implemented as separate config keys[1], but it would be more straightforward to have one config key here and 4 possible values.

Code pointers:

[1] https://opengrok.libreoffice.org/xref/core/officecfg/registry/schema/org/openoffice/Office/Impress.xcs?r=83cc8ef8#973 PageSize PageTile Booklet keys
https://opengrok.libreoffice.org/xref/core/officecfg/registry/schema/org/openoffice/Office/Draw.xcs?r=83cc8ef8#712 same PageSize PageTile Booklet keys

https://opengrok.libreoffice.org/xref/core/sd/source/ui/dlg/prntopts.cxx?r=05f60be4#302 - SdPrintOptions ClickBookletHdl - ui bits 

https://opengrok.libreoffice.org/xref/core/sd/source/ui/app/optsitem.cxx?r=83cc8ef8 SdOptionsMisc::GetPropNameArray and relevant methods in SdOptionsMisc
Comment 1 Stéphane Guillou (stragu) 2023-12-29 23:44:10 UTC
Makes sense -> New.

I notice that switching their values in the Expert Configuration dialog has no impact on the Print > Page Options settings, and that switching one to True will not automatically set the others to False. Is that expected, Gabor?

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 29097009b1f8c0dcb050367d3f2acfcaf2074a56
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded