Bug 158735 - Solver options are no longer saved during a spreadsheet load.
Summary: Solver options are no longer saved during a spreadsheet load.
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.6.0.2 rc
Hardware: All All
: medium normal
Assignee: Rafael Lima
URL:
Whiteboard: target:24.8.0 target:24.2.2 target:7.6.7
Keywords: implementationError
: 159584 160736 (view as bug list)
Depends on:
Blocks: Solver
  Show dependency treegraph
 
Reported: 2023-12-16 19:23 UTC by jsleeth
Modified: 2024-04-19 21:28 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jsleeth 2023-12-16 19:23:04 UTC
Description:
Prior to version 7.6 of Calc, solver options only had to be set one time for a single load of a spread sheet. Since version 7.6 the options have to be reset for each execution of solver on the same load of a spread sheet.  

I suspect that this has something to do with the resolution of bug 38948.

Steps to Reproduce:
1.run a spread sheet
2.run solver and change one or more options
3.check the options before running solver again and observe that your previous options are back to their defaults.

Actual Results:
options only last for a single running of Solver on the same load of a spread sheet.

Expected Results:
Prior to version 7.6 of calc, the options did not go back to defaults after each solver run on a single load


Reproducible: Always


User Profile Reset: No

Additional Info:
For a single load of a spread sheet, the options should not change back to the defaults after each run.
Comment 1 m_a_riosv 2023-12-16 22:50:58 UTC

*** This bug has been marked as a duplicate of bug 38948 ***
Comment 2 ady 2023-12-17 14:12:20 UTC
(In reply to m.a.riosv from comment #1)
> 
> *** This bug has been marked as a duplicate of bug 38948 ***

One of the following alternatives should be true:

* Either the reporter of bug 158735 is confused about the versions in which the problem first showed up (and about the older versions in which there was no problem); 

* or bug 158735 is not really a duplicate of bug 38948.

The versions for each of these 2 reports don't match, and actually they seem quite inverted / opposite to each other.
Comment 3 Rafael Lima 2023-12-17 15:42:04 UTC
(In reply to jsleeth from comment #0)
> Expected Results:
> Prior to version 7.6 of calc, the options did not go back to defaults after
> each solver run on a single load

What solver are you using?

I could reproduce the issue with DEPS and SCO. The model itself is saved, but the solver options are lost.

(In reply to ady from comment #2)
> * or bug 158735 is not really a duplicate of bug 38948.

Indeed this is not a duplicate of bug 38948.

This is a different bug, because when bug 38948 was fixed, the fix did not consider the specific options of the DEPS and SCO solvers.

I am setting this to NEW.

Reproduced in

Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: 60(Build:1)
CPU threads: 12; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+wayland)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 4:7.6.4-0ubuntu0.23.10.1
Calc: threaded
Comment 4 Rafael Lima 2024-03-04 18:01:02 UTC
*** Bug 159584 has been marked as a duplicate of this bug. ***
Comment 5 Rafael Lima 2024-03-04 20:33:12 UTC
Fix available for review here:
https://gerrit.libreoffice.org/c/core/+/164376
Comment 6 Commit Notification 2024-03-06 03:34:12 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/04d884cc99eb66679fb254129b54488bd40e5abf

tdf#158735 Save solver settings for DEPS and SCO as well

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2024-03-07 11:11:43 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/fa8351c50bd8f14830a461c09805e43c6fdb065d

tdf#158735 Save solver settings for DEPS and SCO as well

It will be available in 24.2.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2024-03-24 10:32:01 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/68b0c3a6ac189eea011d1809480e13f7d33652a6

tdf#158735 Save solver settings for DEPS and SCO as well

It will be available in 7.6.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 m_a_riosv 2024-04-19 21:28:29 UTC
*** Bug 160736 has been marked as a duplicate of this bug. ***