Bug 158785 - Hyperlink: help-popup/Ctrl-Click are active one character past the end of the hyperlink
Summary: Hyperlink: help-popup/Ctrl-Click are active one character past the end of the...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Justin L
URL:
Whiteboard: target:24.8.0 target:24.2.0.0.beta2 t...
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Hyperlink
  Show dependency treegraph
 
Reported: 2023-12-19 21:01 UTC by Justin L
Modified: 2024-01-04 14:54 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
smarttag.docx: a hyperlink with a preceeding/following N-dash (5.40 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2023-12-19 21:01 UTC, Justin L
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Justin L 2023-12-19 21:01:08 UTC
Created attachment 191514 [details]
smarttag.docx: a hyperlink with a preceeding/following N-dash

Starting in LO 7.2, at the end of a hyperlink, the helpful popup and the Ctrl-Click are still active on the character following the end of the hyperlink.

commit 3233db0913193855285e1f56492d4617368441b6
Author: Pranam Lashkari on  Mon Feb 1 22:18:01 2021 +0530
    enable hyperlink to be detected at the end of text

Steps to reproduce:
1.) open smarttags.docx
2.) hold down the CTRL key, and approach the hyperlink (www.dordt.edu) from the right. Notice that the cursor changes to a finger already on the N-dash.

See bug 111969 for ideas about how LOKit probably needs to solve this properly.
Comment 1 Stéphane Guillou (stragu) 2023-12-19 21:31:48 UTC
Reproduced in:

Version: 24.2.0.0.beta1 (X86_64) / LibreOffice Community
Build ID: 5f390384195b7264c6e52add9e90a39790285249
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

No repro in:

Version: 7.1.0.3 / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 2 Justin L 2023-12-20 03:58:22 UTC
proposed fix at https://gerrit.libreoffice.org/c/core/+/161042
Comment 3 Commit Notification 2023-12-21 12:14:08 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9b32a016e36fd00c94e17bb5062cf33376d3df3d

tdf#158785 partial revert "enable hyperlink to be detected

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2023-12-21 13:57:22 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/b67f116db12bd2afc6b93ad20eee0696c342f695

tdf#158785 partial revert "enable hyperlink to be detected

It will be available in 24.2.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Stéphane Guillou (stragu) 2023-12-27 09:04:15 UTC
Fix verified in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 40617d867346956588ac023511f31210107217f4
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thanks Justin!
Comment 6 Commit Notification 2024-01-04 14:54:21 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/d0ce236edbaffd8d602951a0acfcba13f6029679

tdf#158785 partial revert "enable hyperlink to be detected

It will be available in 7.6.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.