Bug 158961 - LibreOffice 7.5 Help Module Drop Down Menu Inoperative in Safari 17.2.1 macOS 14.2.1
Summary: LibreOffice 7.5 Help Module Drop Down Menu Inoperative in Safari 17.2.1 macOS...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.5.9.2 release
Hardware: Other macOS (All)
: medium minor
Assignee: Buovjaga
URL:
Whiteboard: target:24.8.0 target:24.2.0.2 target:...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-01 19:02 UTC by James Dening
Modified: 2024-01-06 10:08 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Dening 2024-01-01 19:02:25 UTC
My new LibreOffice suite downloaded from Apple App Store to my Apple Desktop for $8.99 USD is great, but it seems to have a minor bug in the Help 7.5 screen.  The "Language" Drop-Down Menu works, but the "Module" Drop-Down Menu is inoperative when I click on it.  I am running LibreOffice 7.5 but I don't know what version extension I have because I just took what was in the Apple App Store for $8.99 USD.  Here is my environment:

iMac 24" 2021 16GB
Browser Safari 17.2.1 (19617.1.17.11.12)
iMac OS Sonoma 14.2.1

This problem doesn't seem very serious so I'm just bringing it to your attention.  If I am submitting it in error, I apologize.
Comment 1 James Dening 2024-01-01 19:03:35 UTC
Proposed solution would be for the Module Drop Down Menu to work.
Comment 2 Buovjaga 2024-01-01 19:18:37 UTC
Do you get the same result with the Help for the upcoming version: https://help.libreoffice.org/24.2/en-US/text/shared/05/new_help.html
Comment 3 Buovjaga 2024-01-03 06:00:57 UTC
The reporter replied in a private email (please don't do that):

> I get the same result with the Help link you sent me for the latest Help Version.  The drop down menu arrow is still inoperative. The Language down arrow drop down works fine.

Steve: do you also see this with Safari?

The modules menu is populated dynamically upon page load by the setupModules() function in help2.js (I understand this is because of wanting to save some disk space by not writing the stuff to hundreds of pages upon generation). Likewise, the languages menu is populated by setupLanguages(). So I don't know why Safari would discriminate only one of the functions.
Comment 4 steve 2024-01-03 10:55:58 UTC
macOS 13.6.3
Safari 17.2.1 (18617.1.17.11.12, 18617)

Reproduce

1. open LO menubar > Help > LibreOfficeDev Help
2. this will open in default browser
3. this is either safari, if not, copy link into safari
4. click "Module" dropdown

Currently

Nothing happens.

Expected

Dropdown should open. It does work as expected in Firefox.

Confirmed -> new
Comment 5 steve 2024-01-03 10:56:13 UTC
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0f6f5048d223731aa52b768a77244d0208711391
CPU threads: 8; OS: macOS 13.6.3; UI render: Skia/Raster; VCL: osx
Locale: de-DE (en_DE.UTF-8); UI: en-US
Calc: threaded
Comment 6 Buovjaga 2024-01-03 16:28:51 UTC
James: can you check, what it says in the browser's developer console, when you click the modules button?

https://developer.apple.com/documentation/safari-developer-tools/develop-menu https://developer.apple.com/documentation/safari-developer-tools/web-inspector

The "Split Console" area should show any interesting messages while you interact with the page. Maybe some error happens when you click the button?
Comment 7 Buovjaga 2024-01-04 12:57:45 UTC
Heiko tested this and reported: The inspector says = $0 for Modules but not for Languages.

I will look into this more.
Comment 8 Buovjaga 2024-01-04 20:57:24 UTC
Juan José found the related CSS property: overflow-y. Now I managed to test on macOS and I can confirm. However, no value of overflow-y will make the modules nav work.

If I add more children to the nav, eventually it will show (at 15 children). Seems like a bug in Safari/Webkit. Possibly related to the position: absolute rule of the navs?

I see it in Safari 16.
Comment 9 Buovjaga 2024-01-04 21:08:56 UTC
Found the trigger for the bug and submitted a patch: https://gerrit.libreoffice.org/c/help/+/161651
Comment 10 Commit Notification 2024-01-05 12:01:35 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/27088ec11fbefefff49820050a411d5d21e32c6d

tdf#158961 Remove a z-index: 100 rule to keep Safari happy
Comment 11 Commit Notification 2024-01-05 12:04:38 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/help/commit/c903a5157e0b9fe44a624965b642d1af57ec2b28

tdf#158961 Remove a z-index: 100 rule to keep Safari happy
Comment 12 Commit Notification 2024-01-05 12:07:42 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/help/commit/219add06db0e2193170b462ef74956d559ffcbaa

tdf#158961 Remove a z-index: 100 rule to keep Safari happy
Comment 13 steve 2024-01-06 10:08:25 UTC
Fix verified. Nice to see the dropdown functional in Safari, great work.

Safari 17.2.1 (18617.1.17.11.12, 18617)

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 25276df12abd9d002f7f899900434617b256f745
CPU threads: 8; OS: macOS 13.6.3; UI render: Skia/Raster; VCL: osx
Locale: de-DE (en_DE.UTF-8); UI: en-US
Calc: threaded