Bug 159005 - FILESAVE PPTX: Open-Save-Reload changes colors of slide elements
Summary: FILESAVE PPTX: Open-Save-Reload changes colors of slide elements
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: OOXML-Doc-Themes
  Show dependency treegraph
 
Reported: 2024-01-03 20:43 UTC by Alex Heuer
Modified: 2024-01-04 15:59 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Test file to reproduce issue (104.67 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2024-01-03 20:45 UTC, Alex Heuer
Details
Original slide how it looks when opened with MS PowerPoint 365 (40.72 KB, image/png)
2024-01-03 20:48 UTC, Alex Heuer
Details
Screenshot of test file before saving and reopening (50.54 KB, image/png)
2024-01-03 20:48 UTC, Alex Heuer
Details
Screenshot of test.pptx after opening, saving, closing, and reopening the file (62.41 KB, image/png)
2024-01-03 20:49 UTC, Alex Heuer
Details
Screenshot of test.pptx after opening, saving, closing, and reopening the file with 24.08 as of 2024-01-03 (174.23 KB, image/png)
2024-01-04 09:43 UTC, Gerald Pfeifer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Heuer 2024-01-03 20:43:28 UTC
Description:
Similar to this bug:
https://bugs.documentfoundation.org/show_bug.cgi?id=157783

opening a pptx file and then saving it without modifying anything breaks colors of some elements and garbles embedded graph. The problem only occurs with the embedded graph present. 

The embedded graph was inserted via Excel and might have its own color scheme. A hypothesis of mine is that during loading somehow the two color schemes get mixed up. 

Steps to Reproduce:
1.Open attached file
2.Save attached file
3.Open attached file again

Actual Results:
Re-opened file has color changes and the embedded graph is garbled

Expected Results:
No change at all as nothing is modified, the file is just re-saved


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: 60(Build:1)
CPU threads: 24; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: de-DE (en_US.UTF-8); UI: en-US
Ubuntu package version: 4:7.6.4-0ubuntu0.22.04.1~lo1
Calc: threaded
Comment 1 Alex Heuer 2024-01-03 20:45:35 UTC
Created attachment 191737 [details]
Test file to reproduce issue
Comment 2 Alex Heuer 2024-01-03 20:48:08 UTC
Created attachment 191739 [details]
Original slide how it looks when opened with MS PowerPoint 365
Comment 3 Alex Heuer 2024-01-03 20:48:45 UTC
Created attachment 191740 [details]
Screenshot of test file before saving and reopening

The column in 2031 already differs from the original screenshot as there are values printed inside the column
Comment 4 Alex Heuer 2024-01-03 20:49:45 UTC
Created attachment 191741 [details]
Screenshot of test.pptx after opening, saving, closing, and reopening the file
Comment 5 Gerald Pfeifer 2024-01-04 09:43:34 UTC
Created attachment 191748 [details]
Screenshot of test.pptx after opening, saving, closing, and reopening the file with 24.08 as of 2024-01-03

I have good news! What you report is reproducible for me with

  Version: 7.6.4.1 (X86_64) / LibreOffice Community
  Build ID: 60(Build:1)
  CPU threads: 12; OS: Linux 6.6; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US

With the current head of the tree

  Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
  Build ID: 960e37af28807ed1b376e26c4504ab755a81dfd5
  CPU threads: 12; OS: Linux 6.6; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US

and presumably the fix for bug #157783, things already look quite
better. See the new screenshot.

The chart is still garbled and some green still renders as blue, but less.
Comment 6 Gerald Pfeifer 2024-01-04 09:57:09 UTC
What we currently see is identical as with

  Version: 7.6.3.0.0+ (X86_64) / LibreOffice Community
  Build ID: 9c8a1994bea590db7436638580231daf31844fd6
  CPU threads: 12; OS: Linux 6.6; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US

so essentially we are back to before the regressions that was fixed
via bug #157783.


Version: 7.5.6.0.0+ (X86_64) / LibreOffice Community
  Build ID: 0a5c49aa4f65c8e661f7da3934ab9bea8cacf662
  CPU threads: 12; OS: Linux 6.6; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US

garbles the chart, does not change colors, though. So this is a regression.

Version: 7.2.8.0.0+ / LibreOffice Community
  Build ID: d293877ff029ae7c161ccfbade992485fd92fe75
  CPU threads: 12; OS: Linux 6.6; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:libreoffice-7-2, Time: 2022-04-26_20:29:27

does not garble the chart nor change colors, so there appear to be *two* distinct 
regressions here.

Given the title of this report I suggest to focus on the regression
between 7.5 and 7.6.3 (or current top of tree) around color changes.
Comment 7 Gabor Kelemen (allotropia) 2024-01-04 14:45:17 UTC
Looks like the color changes started in 7.6 with:

https://git.libreoffice.org/core/+/dad60bd52a25c1997d3724361ea81c0fe99b1872

author	Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	Sat Feb 25 23:07:20 2023 +0900
committer	Tomaž Vajngerl <quikee@gmail.com>	Sat Apr 08 07:56:27 2023 +0200

oox: add model::Theme to oox::Theme and remove createSvxTheme