Description: Comment triangle border color is varying from cell to cell. Depending on background color set Steps to Reproduce: 1. Open the attached file 2. Look at the border color. Sometimes black/sometimes white Actual Results: Comment triangle border color is varying from cell to cell. Expected Results: Border color of comment should be rather consistent, IMHO Reproducible: Always User Profile Reset: No Additional Info: Version: 24.8.0.0.alpha0+ (x86) / LibreOffice Community Build ID: 3cb1ed4339fc9aec414c0f112a69705a7a4d9cc6 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL threaded
Created attachment 191870 [details] Sample
Created attachment 191871 [details] Screenshot
@Heiko I'm noticing a few more specific issues regarding the comment triangle. It affects the over-all impression.. so my initial thoughts, comment causing eye strain, I want red back, might be less about color and more about other aspects
Created attachment 191875 [details] Screenshot when using cell borders Cell borders needs to be taken into account as relevant factor for the triangle border. Black triangle border blend (and/or overlap) with the black border of the comment. This appears to be quite a complex topic.. I didn't realize it before..
FWIW, the colors of the combination of the "border" of the comment indicator, in addition to the comment indicator itself, are aimed at adding some contrast for 3 related characteristics of the cell: * cell content; contrast against (text/number/value) font color, so users can always read the cell's content while still noticing the presence of the comment indicator. * Cell background; when the cell's background color is similar to the comment indicator's color, the indicator's "border" line helps users in noticing the existence of the indicator, as opposed to completely blend with the background. This is the main reason for the existence of the "border" of the comment indicator. * Cell border: similar to the cell background case. When the cell's border has a color that is similar to the color of the comment indicator, the addition of the "border" for the comment indicator helps users to notice that an indicator is present in the cell. The color of the "border" of the comment indicator needs to always have some contrast against the color of the *comment indicator itself*. That way, whichever the case (colors, themes, combination of cell_background+cell_border+font), the comment indicator can be seen as present in a cell (but never bothering nor distracting). So, whether the color of the "border" of the comment indicator is the same or different than the color of any other property of the cell (except the comment indicator itself), is not important, as long as the user can notice that a comment indicator is there. The user should be able to see either the "interior" of the indicator, or the "border" of the indicator, or both.
As ady commented, the indicator border is needed when the color has low contrast to the cell background. And it is intentionally bright/dark depending on the luminance. => NAB
I changed the border color as part of bug 158958 (save space for the cell content). It use the grid color now so the triangle could be moved to the very edge of the cell (actually just one pixel).
@Eyal FYI, in relation to bug 159096 comment 11
> the indicator border is needed when the color has low contrast to the cell background. Nope. If anything is needed (*), it's a variation on how the triangle is applied (as a "layer" onto another "layer"). I don't buy the border as it is now (regardless of the color). (*) I'm not even sure it's a good idea to play with the comment indicator's appearance, even if it's fully merged into the cell background. Some kind of highlight-on-mouse-over might be sufficient.
(In reply to Eyal Rozenberg from comment #9) > (*) I'm not even sure it's a good idea to play with the comment indicator's > appearance, even if it's fully merged into the cell background. Some kind of > highlight-on-mouse-over might be sufficient. You are suggesting to get rid of the indicator, entirely. If the user has to hover over cells to find out which one has a comment, the comment itself will show up, so no need for the indicator. Clearly that's not helpful, for those many users that rely on having the indicator present (on who knows how many cells to check for the present of comments).
Heiko Tietze committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bddae0d0dc4f64757100e00432ca40a6470d2c31 Resolves tdf#158958 and tdf#159124 - Improvements to Comments indicator It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to ady from comment #10) > You are suggesting to get rid of the indicator, entirely. No I'm not. > If the user has to > hover over cells to find out which one has a comment, the comment itself > will show up, so no need for the indicator. That will only happen if the user set the cell background to red, or magenta, or whatever the indicator is. It is not unlike setting a highlight color to the page background color, or setting the font color to the cell background color etc. > Clearly that's not helpful, for those many users that rely on having the > indicator present I claim that users who set cell backgrounds to the comment indicator color do not rely on easy identification of comment indicators.