Bug 159131 - Calc v7.5 is laggy when moving a line (row)
Summary: Calc v7.5 is laggy when moving a line (row)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: Other Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.8.0 target:7.6.5 target:24.2.1
Keywords: perf
Depends on:
Blocks:
 
Reported: 2024-01-11 13:34 UTC by Philemon
Modified: 2024-02-01 13:32 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Calc options (25.57 KB, image/png)
2024-01-11 16:44 UTC, Philemon
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philemon 2024-01-11 13:34:41 UTC
Description:
The latest version of Calc has becomed laggy when : select a complete row, move it down or up by "grabbing" a cell with the mouse : this simple operation takes 1 or 2 seconds. On the same pc, version 6 does the same operation instantly.
It's laggy even if the spreadsheet is empty.
A columns move on version 7 is not affected by lag.

All this clues indicate that the high number of columns (16384) could be the cause of the lag.
Do you think, dev. people, that an option could settle this lost of performance? I'm not sure that a total number of columns could be set/chosen, because it surely would be a mess with compatibility...
But I'm interessed about it. Thanks for your attention


Steps to Reproduce:
1.Select a complete row, move it down or up by "grabbing" a cell with the mouse

Actual Results:
2 seconds operation, mouse freezes during 1 second

Expected Results:
Instantly (less than 1 second)


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.5.9.2 (X86_64) / LibreOffice Community
Build ID: cdeefe45c17511d326101eed8008ac4092f278a9
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: threaded

Hardware : Intel Core(TM) i3-7100 CPU @ 3.90GHz 3.91 GHz
8 Go RAM
Windows 10
Comment 1 m_a_riosv 2024-01-11 16:29:46 UTC
Menu/Tools/Options/LibreOffice Calc/Defaults
Comment 2 Philemon 2024-01-11 16:44:10 UTC
Created attachment 191879 [details]
Calc options

There is no option for columns number.
I'm not sure that option would be possible, because it would change the default work space of Calc.
Unfortunately, the high number of columns slows the programm down.
Comment 3 m_a_riosv 2024-01-11 16:46:52 UTC
Enable first 
Menu/Tools/Options/LibreOffice/Advanced - Enable experimental features
Comment 4 Philemon 2024-01-11 16:57:32 UTC
Thanks for the tip, but : the experimental options let you choose "very large sheet", that's all (16 billion rows).
With "very large sheet" unchecked, the normal sheet stays at 16384 columns.
Previous versions of Calc were limited to about 1200 columns.
Comment 5 ady 2024-01-11 17:04:37 UTC
(In reply to m_a_riosv from comment #1)
> Menu/Tools/Options/LibreOffice Calc/Defaults

That is only relevant when advance experimental options are available. Otherwise, only the default amount of worksheets can be set.

Even when allowing advance experimental options, setting that option ON is the opposite of what is being requested here (in a way); i.e. for the user to be able to reduce the amount of supported columns from 16384 (since LO 7.4) to 1024 (as it used to be), in order for Calc to react faster to some actions that are affected by the (new) amount of supported columns.

Of course, that request assumes that:
* reducing the max amount of columns is possible, and that
* once reduced, it will ("automagically") make Calc react faster.

Alternatively, the request is for the specific action described in comment 1 to perform as fast as it used to be.
Comment 6 m_a_riosv 2024-01-12 15:42:44 UTC
(In reply to Philemon from comment #4)
> Thanks for the tip, but : the experimental options let you choose "very
> large sheet", that's all (16 billion rows).
> With "very large sheet" unchecked, the normal sheet stays at 16384 columns.
> Previous versions of Calc were limited to about 1200 columns.

Right, sorry.

Couple of things to test:
Menu/Tools/LibreOffice/OpenCL
Menu/Tools/LibreOffice/View - skia.
Comment 7 Philemon 2024-01-12 21:32:28 UTC
(In reply to m_a_riosv from comment #6)
>
> Couple of things to test:
> Menu/Tools/LibreOffice/OpenCL
> Menu/Tools/LibreOffice/View - skia.

Thanks for the good idea. I actually tried these options, but they have no effect on the row lag, as I supposed.

- Skia makes little display bugs on my office pc, but no lag ; Skia works fine on a powerfull pc.
- I tried LO 7.5 at home : even with a strong config (RTX 3060, Ryzen 5 3600, 16Go RAM), a clear 1 second lag does exist at each row move.
That's why I believe in my theory of high number of columns that could affect row optimisation.
That's not a big deal, but quite annoying, especially as previous versions were fine optimized. However, I understand the necessity of LO upgrade, 16384 columns will be usefull for many people.
Comment 8 Buovjaga 2024-01-24 16:00:20 UTC
I bibisected the appearance of the lag with win64-7.5 to 69910b540ae5140123fd2d4d67a9d338f980db53
tdf#54857 improve resizing of columns

Noel: any thoughts? I notice bug 54857 is about binary PPT files, so I wonder what was the context there :)

Anyway, it doesn't seem related to the jumbo sheet support, because the option was not active for me in Calc Defaults option page.
Comment 9 Noel Grandin 2024-01-30 11:54:28 UTC
Potential fix  https://gerrit.libreoffice.org/c/core/+/162746
Comment 10 Commit Notification 2024-01-30 19:12:46 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/21dd07f95d7dcb95f243753306108c18d9ba115a

tdf#159131 Calc is laggy when moving a line (row)

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Buovjaga 2024-01-31 06:34:46 UTC
I confirm the lag is gone now in

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: dfcdef6d94993131b5f150d00d08cc81a987eebb
CPU threads: 2; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Thanks!

Others can test with Win-x86_64@tb77-TDF from https://dev-builds.libreoffice.org/daily/master/current.html
Comment 12 Commit Notification 2024-01-31 13:33:08 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/75b430e5a8e8e6e9e234168dd71fa97100a5b09b

tdf#159131 Calc is laggy when moving a line (row)

It will be available in 7.6.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2024-01-31 19:59:03 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/d891af6d9b876b172a77df5315c0a176f8dbdc6f

tdf#159131 Calc is laggy when moving a line (row)

It will be available in 24.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Philemon 2024-02-01 13:32:11 UTC
I confirm too, there is a visible benefit.
Approximately : problematic lag = 0.8 sec ; with patch = 0.25 sec ; previous versions (v6, or 7.1) = 0.10 sec or less.
This is an approximation, I didn't measure it. After patch, the ergonomy can not be considered affected.
One can notice once again the lags are the same on a basic office pc, or on a powerfull pc.

Thanks for your developments !


PC 1 : Windows 10, Intel Core i3-7100 CPU @ 3.90GHz 3.91 GHz, 8Go RAM
PC 2 : Windows 11, AMD 5 3600, 16Go RAM