Bug 159147 - CRASH: Editing hyperlink while navigator is open
Summary: CRASH: Editing hyperlink while navigator is open
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Jim Raykowski
URL:
Whiteboard: target:24.8.0 target:24.2.0.3 target:...
Keywords:
Depends on:
Blocks: Hyperlink-Dialog
  Show dependency treegraph
 
Reported: 2024-01-12 11:47 UTC by Xisco Faulí
Modified: 2024-01-24 15:58 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
screencast (12.96 MB, video/mp4)
2024-01-12 11:47 UTC, Xisco Faulí
Details
gdb bt (6.07 KB, text/plain)
2024-01-12 20:07 UTC, Julien Nabet
Details
visual explaination of crash (602.36 KB, video/x-matroska)
2024-01-16 20:46 UTC, Jim Raykowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2024-01-12 11:47:15 UTC
Created attachment 191888 [details]
screencast

Steps to reproduce:
1. Open Writer
2. Open the navigator
3. Insert an hyperlink
4. Insert a second edit
5. Edit the first hyperlink and click on Apply. If it doesn't crash close the dialog and try again with the other hyperlink. At some point it will crash since it doesn't always crash at the same point

Reproduced in

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 84a3401c28135735c7bbe324eb3642b31c7f26f5
CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: x11
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded
Comment 1 Xisco Faulí 2024-01-12 11:48:32 UTC
Hi Jim, I thought you might be interested in this issue
Comment 2 Xisco Faulí 2024-01-12 13:59:41 UTC
Also reproduced in

Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 1c629ca0048670db4bed5e7d8d76bcf8e81f2158
CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: x11
Locale: fr-FR (es_ES.UTF-8); UI: en-US
Calc: threaded
Comment 3 Julien Nabet 2024-01-12 20:07:21 UTC
Created attachment 191901 [details]
gdb bt

On pc Debian x86-64 with master sources updated today, I got an assertion.
Comment 4 Jim Raykowski 2024-01-13 09:09:53 UTC
Thanks Julien for the backtrace.

Proposed fix is here:
https://gerrit.libreoffice.org/c/core/+/162013
Comment 5 Jim Raykowski 2024-01-16 20:46:15 UTC
Created attachment 192005 [details]
visual explaination of crash
Comment 6 Commit Notification 2024-01-17 15:48:35 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b2500f0e32b33eec2740dc370238f66fb8b50ffb

tdf#159147 Fix crash when editing hyperlink while navigator is open

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2024-01-17 19:26:58 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/e8877f971a4b50e58bbbe3df1e14cde1a2e0d694

tdf#159147 Fix crash when editing hyperlink while navigator is open

It will be available in 24.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2024-01-17 19:28:01 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/421f5394c29763a4f766a4fe4656bb948979ee1d

tdf#159147 Fix crash when editing hyperlink while navigator is open

It will be available in 7.6.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2024-01-19 15:44:10 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a08197e7c376c72685260ae923483ae99f929d35

tdf#159147 followup

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2024-01-21 12:18:27 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/2e65401cf50ca25e16a0f3d4b624e2b48c97644c

tdf#159147 followup

It will be available in 7.6.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2024-01-21 12:18:29 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/cafcc50570f9edaaebe74d2152bae5df1cc2edfe

tdf#159147 followup

It will be available in 24.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2024-01-24 08:28:04 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-24-2-0":

https://git.libreoffice.org/core/commit/553b91ef4204d0d6473f45ceadb76d6e24a08879

tdf#159147 Fix crash when editing hyperlink while navigator is open

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.