Bug 159157 - FILEOPEN DOCX: image offset in opposite direction of TEXT_LINE what vertical offset specifies
Summary: FILEOPEN DOCX: image offset in opposite direction of TEXT_LINE what vertical ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Justin L
URL:
Whiteboard: target:24.8.0 target:24.2.1
Keywords: bibisected, implementationError, notBibisectable
Depends on:
Blocks: Anchor-and-Text-Wrap
  Show dependency treegraph
 
Reported: 2024-01-12 18:22 UTC by Justin L
Modified: 2024-01-15 13:18 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
n747461_2019.docx: images should be .6 to 1.1cm below (the top of the) line (13.61 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2024-01-12 18:22 UTC, Justin L
Details
n747461_2019.pdf: Generated by MSO 2019, same as it is in 2010 (17.87 KB, application/pdf)
2024-01-12 20:57 UTC, Justin L
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Justin L 2024-01-12 18:22:58 UTC
Created attachment 191899 [details]
n747461_2019.docx: images should be .6 to 1.1cm below (the top of the) line

While working on bug 139915, I noticed that my export fix caused ooxmlexport8's n747461.docx to alternate between above and below the line for each round-trip. Microsoft Office displays each version the OPPOSITE way that LO does - so that indicates that the export change is correct, and that LO simply is importing it wrong. So it sounds like vmiklos' tdf#139915 import fix for textboxes needs to be applied to images as well.

Steps to reproduce
1.) open n747461_2019.docx. (The shapes should be lower than the word "line".)

Already seen in LO 3.5. Prior to that the shapes overlapped each other and had no offset at all.
Comment 1 Justin L 2024-01-12 20:57:27 UTC
Created attachment 191902 [details]
n747461_2019.pdf: Generated by MSO 2019, same as it is in 2010
Comment 2 Commit Notification 2024-01-13 00:54:19 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/29cd541dfcff93a50c2e1ae9eab74f1908214c2e

tdf#139915 tdf#159157 writerfilter: fix image position with TEXT_LINE

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2024-01-15 07:52:19 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/8132f0eb48d1b1601b690c43bcd4991c86dd1217

tdf#139915 tdf#159157 writerfilter: fix image position with TEXT_LINE

It will be available in 24.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.