Bug 159185 - Expert config dialog accepts letters in numeric keys edit fields
Summary: Expert config dialog accepts letters in numeric keys edit fields
Status: UNCONFIRMED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha0+
Hardware: All All
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks: Options-Dialog-Expert
  Show dependency treegraph
 
Reported: 2024-01-15 01:32 UTC by Gabor Kelemen (allotropia)
Modified: 2024-01-29 02:42 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Before editing some int type keys value (47.83 KB, image/png)
2024-01-15 01:32 UTC, Gabor Kelemen (allotropia)
Details
Typing letters is accepted (47.07 KB, image/png)
2024-01-15 01:32 UTC, Gabor Kelemen (allotropia)
Details
After moving focus the letters become 0 (41.22 KB, image/png)
2024-01-15 01:33 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2024-01-15 01:32:10 UTC
Created attachment 191934 [details]
Before editing some int type keys value

If the value of an int type key is edited, the edit box accepts non-numeric input and resets it to 0 value.
In 7.6 only numbers were accepted.

1. Go to Tools - Options - Advanced
2. Press the Open Expert Configuration button
3. Edit any key with a type of int
4. Type some letters into the Edit box, press TAB to focus out of the field
-> value changes to 0, this can be acknowledged by the OK button

In 7.6, letters were not accepted int such cases.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 84a3401c28135735c7bbe324eb3642b31c7f26f5
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

Seems to have started in:

https://git.libreoffice.org/core/+/ee4eb828fbf7ead62fca85239d78c48003bbc41e

author	Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>	Thu Nov 09 12:56:30 2023 +0100
committer	Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>	Mon Nov 13 10:38:37 2023 +0100

Use SvxNameDialog for editing config values
Comment 1 Gabor Kelemen (allotropia) 2024-01-15 01:32:28 UTC
Created attachment 191935 [details]
Typing letters is accepted
Comment 2 Gabor Kelemen (allotropia) 2024-01-15 01:33:31 UTC
Created attachment 191936 [details]
After moving focus the letters become 0
Comment 3 Samuel Mehrbrodt (allotropia) 2024-01-15 07:23:32 UTC
That's a side effect of converting the widget to a proper number dialog.
The number dialog accepts non-numeric input, probably because one could also enter units.

Not sure how/if this is fixable.

@Caolan: Any idea here?
Comment 4 Caolán McNamara 2024-01-15 09:38:23 UTC
Personally I wouldn't "fix" it, let them enter what they want while editing as long as it turns into a number in the end, even if that's 0.

Otherwise its probably back to using "connect_key_press" to filter what is entered
Comment 5 Stéphane Guillou (stragu) 2024-01-29 02:42:01 UTC
This is pretty common behaviour in many dialogs, allow typing letters then promptly replacing them by a value. So I'd tend to agree with "won't fix", as long as the replacement value is sensible.

One side note, Samuel: the dialog's Help button leads to nowhere, with HID=cui/ui/numberdialog/box1