Bug 159207 - FILEOPEN DOCX/RTF Frame opens with unwanted left border
Summary: FILEOPEN DOCX/RTF Frame opens with unwanted left border
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Justin L
URL:
Whiteboard: target:24.8.0 target:24.2.1 target:7.6.5
Keywords:
Depends on:
Blocks: RTF-Paragraph
  Show dependency treegraph
 
Reported: 2024-01-15 22:29 UTC by Gabor Kelemen (allotropia)
Modified: 2024-01-24 08:16 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
The example file in Word 2016 and current master (196.55 KB, image/png)
2024-01-15 22:29 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2024-01-15 22:29:57 UTC
Created attachment 191971 [details]
The example file in Word 2016 and current master

When opening attachment 151650 [details] from bug 125473, the footer contains a frame, which has a left border set.

1. Open attachment 151650 [details] 
-> there is a frame in the footer, which should not have a left border.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 25276df12abd9d002f7f899900434617b256f745
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (hu_HU); UI: de-DE
Calc: threaded

Looks the same if saved as docx in Word.
This happens since commit:

https://git.libreoffice.org/core/+/31ea6305b6a763ee48f639562313d9bd109a2923%5E%21/#F2

author	Justin Luth <justin.luth@collabora.com>	Sat Apr 08 08:22:45 2023 -0400
committer	Justin Luth <jluth@mail.com>	Sat Apr 08 20:10:09 2023 +0200
tree 6032ceaafca3ba4514811453ca20af8b136dcb25
parent 02bf9a2e65042afc224f52680cbcfcf30e298ad1 [diff]

tdf#154703 writerfilter framePr: avoid exception with hasValue

Before this the frame was not imported at all, so not a regression.
Comment 1 Justin L 2024-01-23 18:06:50 UTC
Oops - I put the wrong bug number in the patches.

Justin Luth committed a patch related to this issue.
It has been pushed to "master" (and 24.2, and in the queue for 7.6)

https://git.libreoffice.org/core/commit/05e637b36043fac83265bbdfbdba97632a8e939e

tdf#154703 writerfilter framePr: avoid unexpected frame borders

It will be available in 24.8.0, and 24.2.1, and likely in 7.6.5.
Comment 2 Commit Notification 2024-01-24 08:16:54 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/4d3e10fe4503810f17c60443b84a300a543a44b6

tdf#159207 writerfilter framePr: avoid unexpected frame borders

It will be available in 7.6.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.