Writer: insert a chart > insert trendline => crash. Same for Calc for a chart with a few data points. soffice.bin: /home/ht/Sources/libreoffice/vcl/source/app/dbggui.cxx:35: void ImplDbgTestSolarMutex(): Assertion `ImplGetSVData()->mpDefInst->GetYieldMutex()->IsCurrentThread() && "SolarMutex not owned!"' failed.
Created attachment 192072 [details] bt On pc Debian x86-64 with master sources updated today, I could reproduce the assertion.
Noel: noticing a2e78d06df22e99f2dc82ee3245ddc4c5de56acf fix concurrent access to fontcache I thought you might have some idea how to fix this.
I tried this: diff --git a/chart2/source/tools/CharacterProperties.cxx b/chart2/source/tools/CharacterProperties.cxx index 7669d3245a27..3e35f002a9a0 100644 --- a/chart2/source/tools/CharacterProperties.cxx +++ b/chart2/source/tools/CharacterProperties.cxx @@ -36,6 +36,7 @@ #include <i18nlangtag/mslangid.hxx> #include <i18nlangtag/languagetag.hxx> #include <tools/color.hxx> +#include <vcl/svapp.hxx> #include <vcl/outdev.hxx> using namespace ::com::sun::star; @@ -340,6 +341,7 @@ void CharacterProperties::AddPropertiesToVector( void CharacterProperties::AddDefaultsToMap( ::chart::tPropertyValueMap & rOutMap ) { + SolarMutexGuard aGuard; const float fDefaultFontHeight = 13.0; SvtLinguConfig aLinguConfig; It worked. Now I know nothing about SolarMutexGuard except the fact we don't want to overuseit.
Julien's patch looks good
(In reply to Noel Grandin from comment #4) > Julien's patch looks good Thank you for the feedback, I put you in reviewer of https://gerrit.libreoffice.org/c/core/+/162737.
Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/dd5e179f0fd7c9bf37872acf53301be28bb71cfc tdf#159288: Assertion on insert trend line It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Xisco has cherry-picked the fix for 24.2 here: https://gerrit.libreoffice.org/c/core/+/162722 (thank you Xisco!)
Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/dea542e3b4216b41b3593485caa7d21cd2195041 tdf#159288: Assertion on insert trend line It will be available in 24.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.