Bug 159296 - Wrong information shown in tip of the day
Summary: Wrong information shown in tip of the day
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.5.3.2 release
Hardware: All macOS (All)
: medium trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillCpp
Depends on:
Blocks: Tip-Of-The-Day
  Show dependency tree / graph
 
Reported: 2024-01-20 04:30 UTC by bcling
Modified: 2024-01-22 09:22 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description bcling 2024-01-20 04:30:27 UTC 
Description:
Tip of the Day: 45/224 is incorrect.

The correct key combination to select the current column is CONTROL+SPACE, not Command+Space (which is set by default to Spotlight in macOS).

Steps to Reproduce:
1. Start LibreOffice
2. Read Tip of the Day #45/224

Actual Results:
Command+Space brings up Spotlight search.

Expected Results:
Instructions should read "Control+Space to select the current column."


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.5.3.2 (X86_64) / LibreOffice Community
Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3
CPU threads: 4; OS: Mac OS X 14.1.2; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Julien Nabet 2024-01-21 15:18:05 UTC 
I'm not on macOS but I noticed:
   1416         <node oor:name="SPACE_MOD1" oor:op="replace">
   1417           <prop oor:name="Command">
   1418             <value xml:lang="x-no-translate">L10N SHORTCUTS - NO TRANSLATE</value>
   1419             <value xml:lang="en-US" install:module="unxwnt">.uno:SelectColumn</value>
   1420           </prop>
   1421         </node>
   1422         <node oor:name="SPACE_MOD3" oor:op="replace">
   1423           <prop oor:name="Command">
   1424             <value xml:lang="x-no-translate">L10N SHORTCUTS - NO TRANSLATE</value>
   1425             <value xml:lang="en-US" install:module="macosx">.uno:SelectColumn</value>
   1426           </prop>
   1427         </node>

in officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
(see https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/Accelerators.xcu#1416)

But in cui/inc/tipoftheday.hrc or cui/source/dialogs/tipofthedaydlg.cxx, there's no MOD3.

Heiko: thought you might be interested in this one since it concerns TOTD.
Comment 2 Heiko Tietze 2024-01-22 09:22:55 UTC 
The tip is "Use Shift+Space to select the current row and %MOD1+Space to select the current column.". 

The %MOD replacement is done in cui/source/dialogs/tipofthedaydlg.cxx; simply follow the example of m_pText->set_label(CuiResId(sTip).replaceAll("%MOD1", aMOD1).replaceAll("%MOD2", aMOD2)); or rather extend the function.

aMod1/2 are assigned above

  #ifdef MACOSX
      const OUString aMOD1 = CuiResId(STR_CMD);
      const OUString aMOD2 = CuiResId(STR_Option);
...

And defined  at the end of the hrc file. I'd use something like

#define STR_CARET                      NC_("STR_CARET", "⌃ Ctrl")
#define STR_SHIFT                      NC_("STR_SHIFT", "Shift")

We use Shift on many tips, and some might be "^ Ctrl" on macOS. Needs to be double-checked with what is actually assigned in Accelerators.xcu.


For MOD3 = Ctrl see AquaSalFrame::GetKeyName() in vcl/osx/salframe.cxx.