Bug 159329 - Arrows in AutoFilter are black over dark background
Summary: Arrows in AutoFilter are black over dark background
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.6.4.1 release
Hardware: All All
: medium normal
Assignee: Rafael Lima
URL:
Whiteboard: target:24.8.0 target:24.2.1 target:7.6.5
Keywords:
Depends on:
Blocks: Dark-Mode
  Show dependency treegraph
 
Reported: 2024-01-22 17:35 UTC by Rafael Lima
Modified: 2024-01-30 08:28 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Simple AutoFilter file for testing (9.95 KB, application/vnd.oasis.opendocument.spreadsheet)
2024-01-22 17:35 UTC, Rafael Lima
Details
Screenshot showing the problem (107.71 KB, image/png)
2024-01-22 17:37 UTC, Rafael Lima
Details
Screenshot on windows (85.70 KB, image/png)
2024-01-22 22:40 UTC, m_a_riosv
Details
Screenshot on windows with system dark theme (79.04 KB, image/png)
2024-01-23 23:13 UTC, m_a_riosv
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2024-01-22 17:35:08 UTC
Created attachment 192102 [details]
Simple AutoFilter file for testing

Steps to reproduce

0) Make sure you're using dark mode
1) Open attached sample file in LO Calc 7.6 or newer
2) Click the down arrow in the AutoFilter
3) The right arrows in the AutoFilter are black over a dark background

This issue happens in kf5 and gtk3. I haven't tested in Win/Osx.

This issue had actually been fixed for LO 7.5 (see bug 151820) but it came back in LO 7.6.

If anyone can please confirm this issue, let me know. The fix is simple.

System info

Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: 60(Build:1)
CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 4:7.6.4-0ubuntu0.23.10.1
Calc: threaded
Comment 1 Rafael Lima 2024-01-22 17:37:29 UTC
Created attachment 192103 [details]
Screenshot showing the problem

This screenshot shows the problem in kf5 (Kubuntu) and gtk3 (using Ubuntu/Gnome).
Comment 2 m_a_riosv 2024-01-22 22:40:40 UTC
Created attachment 192107 [details]
Screenshot on windows

Not repro
Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
Comment 3 Rafael Lima 2024-01-23 22:35:07 UTC
(In reply to m_a_riosv from comment #2)
> Created attachment 192107 [details]
> Screenshot on windows

This only happens if your system colors are set to dark mode.
Comment 4 m_a_riosv 2024-01-23 23:13:45 UTC
Created attachment 192132 [details]
Screenshot on windows with system dark theme

Not reproducible with system dark theme
Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
Comment 5 Rafael Lima 2024-01-23 23:27:18 UTC
(In reply to m_a_riosv from comment #4)
> Created attachment 192132 [details]
> Screenshot on windows with system dark theme

You have to click the "down arrow" and then the arrows inside the AutoFilter dialog will be black over dark background.
Comment 6 m_a_riosv 2024-01-23 23:37:51 UTC
Ok, reproducible now
Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
Comment 7 m_a_riosv 2024-01-23 23:39:38 UTC
Also reproducible with
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d49b0c3654e50ff9b74545140e6f19e008009c33
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
Comment 8 Rafael Lima 2024-01-23 23:40:40 UTC
(In reply to m_a_riosv from comment #6)
> Ok, reproducible now

Thanks for confirming.

Patch here:
https://gerrit.libreoffice.org/c/core/+/162460
Comment 9 Commit Notification 2024-01-26 13:38:14 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b0f678ca59a65a3c302c3c3a499230fbc52ed5bd

tdf#159329 Fix AutoFilter arrow color in dark mode

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2024-01-29 09:22:40 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/d60520f8aabefd8f2893b8656c555c25be93c16c

tdf#159329 Fix AutoFilter arrow color in dark mode

It will be available in 24.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2024-01-30 08:28:56 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/341840f4f97ca03b3d2e416014f4f406cb8b2a2f

tdf#159329 Fix AutoFilter arrow color in dark mode

It will be available in 7.6.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.