Bug 159461 - Dialog "XML Filter Settings" is broken
Summary: Dialog "XML Filter Settings" is broken
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.6.0.0 alpha1+
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.8.0 target:24.2.1 target:7....
Keywords: bibisected, haveBacktrace, regression
Depends on:
Blocks:
 
Reported: 2024-01-30 17:32 UTC by Manuel Reimer
Modified: 2024-06-07 06:21 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
random bt (6.31 KB, text/plain)
2024-02-01 12:48 UTC, Julien Nabet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Reimer 2024-01-30 17:32:14 UTC
Description:
I wanted to follow the tutorial posted here:
https://forum.openoffice.org/en/forum/viewtopic.php?t=3490

When doing so ("Tools" -> "XML Filter Settings..." -> "New...", enter data) and pressing "OK", then the dialog just hangs until Gnome asks me to forcefully quit the application.

So my next try was to probably work around this by exporting an existing entry, editing it outside of Libre Office and importing it again. But if I use "Save as Package..." on any existing item, then all I get is an empty ".jar" file with only an empty directory inside it. Opening this file again throws an error message

No XML filter could be installed because the package 'test.jar' does not contain any XML filters.

So at least for me the whole XML filter dialog is broken completely. Seems to be impossible to create a new XML filter.

Steps to Reproduce:
Try to follow the tutorial here:
https://forum.openoffice.org/en/forum/viewtopic.php?t=3490
To create a new XML filter.

Actual Results:
Dialog hangs

Expected Results:
Filter creating should work


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: 60(Build:1)
CPU threads: 6; OS: Linux 6.7; UI render: default; VCL: gtk3
Locale: de-DE (en_US.UTF-8); UI: en-US
7.6.4-2
Calc: threaded
Comment 1 Manuel Reimer 2024-01-30 17:33:57 UTC
There is an even easier way to reproduce the issue.

- Open the XML filter settings dialog
- Choose any existing entry
- Click on "Edit..."
- Click on "OK" in the now opening dialog

--> LibreOffice hangs
Comment 2 m_a_riosv 2024-01-30 23:13:40 UTC
Still reproducible with
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 3be785e088cc0aa726509cf6b52b1d3b03817172
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: es-ES
Calc: CL threaded
Comment 3 Julien Nabet 2024-02-01 12:48:57 UTC
Created attachment 192323 [details]
random bt

On pc Debian x86-64 with master sources updated today, I could reproduce this.

I attached a bt.
Comment 4 Julien Nabet 2024-02-01 12:50:51 UTC
I forgot to tell I tested comment 1 process:
- Open the XML filter settings dialog
- Choose any existing entry
- Click on "Edit..."
- Click on "OK" in the now opening dialog

Noel: reverting 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=15405dc68b2e88b53585578567da13e3e99962db
osl::Mutex->std::mutex in FilterCache

makes it work again.

Any idea?
Comment 5 Julien Nabet 2024-02-02 06:34:18 UTC
The commit has been identified, see previous comment
Comment 6 Commit Notification 2024-02-02 19:40:54 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b23aec2266da4cc2b3f4a34037d3a073a36d3d83

tdf#159461 deadlock in Dialog "XML Filter Settings"

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Julien Nabet 2024-02-02 20:51:41 UTC
On pc Debian x86-64 with master sources updated today (including Noel's patch), I confirm I don't reproduce the hang anymore.
Comment 8 Commit Notification 2024-02-06 09:27:44 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/9c5500973bd99ef1323c85c6eefad86c86983f56

tdf#159461 deadlock in Dialog "XML Filter Settings"

It will be available in 24.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2024-02-07 07:24:19 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/83b173b9eacccf00aa7f51214fb2e3d464acf80f

tdf#159461 deadlock in Dialog "XML Filter Settings"

It will be available in 7.6.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2024-02-15 15:10:33 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-7-6-5":

https://git.libreoffice.org/core/commit/0d6f724643d73c6ddc2a4e74ffbd476cb4105ec3

tdf#159461 deadlock in Dialog "XML Filter Settings"

It will be available in 7.6.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.