Bug 159569 - Conditional Formatting dialog's fields are out of view when long message appears
Summary: Conditional Formatting dialog's fields are out of view when long message appears
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.5.3.2 release
Hardware: x86-64 (AMD64) All
: medium minor
Assignee: Heiko Tietze
URL:
Whiteboard: target:24.8.0 target:24.2.4
Keywords: needsDevEval, topicUI
Depends on:
Blocks: Conditional-Formatting-Editing
  Show dependency treegraph
 
Reported: 2024-02-05 12:15 UTC by Erwinneke
Modified: 2024-04-24 19:48 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Input field disappears when entering a letter (85.40 KB, image/png)
2024-02-05 12:15 UTC, Erwinneke
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Erwinneke 2024-02-05 12:15:51 UTC
Created attachment 192409 [details]
Input field disappears when entering a letter

As soon as I input a letter (or number+letter) the field disappears.
It re-appears by enlarging the window (picture incl.)
Comment 1 m_a_riosv 2024-02-05 13:01:44 UTC
I can't reproduce with
Version: 7.6.5.0.0+ (X86_64) / LibreOffice Community
Build ID: 2e65401cf50ca25e16a0f3d4b624e2b48c97644c
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: default; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded

Please test in safe mode, Menu/Help/Restart in Safe Mode
Comment 2 ady 2024-02-05 14:04:13 UTC
Interestingly, at first I did not reproduce using English UI, but trying some other UI language (e.g. Italian), I can see the dialogue's fields expanding as soon as I introduce a value into the field. Setting back the UI to English, now I can also reproduce the behavior in English too.

So this might not be really dependent on UI language, but rather on having the size of the dialogue's window modified at least once (from the initial default size), and shrinking it again. After that, you might be able to reproduce the behavior. TBH, I am not sure.

I can reproduce this using LO 7.5.3.2 and also on a recent 24.8 alpha. I was not able to reproduce this on 7.4.

If I delete the value immediately, the fields also shrink back.

After resizing (expanding sideways) the window one time, the next time I open it the new size was kept/saved, even after closing LO and re-opening it, so the behavior (fields expanding when a value is introduced) is no longer visible in that case.

If I shrink the window again, I can repro the behavior again.

The other item that also changes simultaneously (while the fields expand) is the text under them (i.e. the text itself). I mention this just in case the behavior and the display of the text have some relation.
Comment 3 Stéphane Guillou (stragu) 2024-02-05 14:17:40 UTC
In my testing, it is specific to the length of the translated message in some translations: the Dutch UI used here, and any other language that has a long message that overflows the dialog.

In English, the string is shorter and fits the original width of the dialog:
"Strings without quotes are interpreted as defined names or references or column/row labels."

I tested on Linux with the French UI, which also has a long translation. With the gtk3 VCL plugin, the dialog widens automatically to make it fit, so the issue is not reproducible. However, with the gen VCL plugin, I reproduce:

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11
Locale: en-AU (en_AU.UTF-8); UI: fr-FR
Calc: threaded

So the solution would be to either increase the width of the dialog to accommodate a message when it appears (as in gtk3 currently) or wrap the message according to the available space (which I think is a better solution, to respect the width the user has set, and avoid a jumping UI).
Comment 4 ady 2024-02-05 14:33:41 UTC
(In reply to Stéphane Guillou (stragu) from comment #3)

> In English, the string is shorter and fits the original width of the dialog:
> "Strings without quotes are interpreted as defined names or references or
> column/row labels."

When I went back to English UI and I manually shrank the size of the dialogue, I can still repro, even though the message can be completely seen within the minimal size.

Using that text length and from the POV of the user, the reason/need to expand the dialogue is not so clear. I mention this for the UX team, in case it happens to be relevant in the potential decision of "what exactly would trigger an expansion (in whichever direction, if needed)".

As mentioned, manually resizing the dialogue (once) overcomes the behavior.
Comment 5 Heiko Tietze 2024-02-05 16:15:06 UTC
Happens when you insert text and the warning "Strings without quotes are interpreted as defined names or references or column/row labels." appear. The label is "valueft" in conditionalentry.ui (unclear what happens on mobile devices for conditionalentrymobile.ui). The label seems to be full-sized, so no issue on the first glance. Maybe it depends on some other control- the ui is quite complex.
Comment 6 Gwenaël Q. 2024-03-01 19:33:04 UTC
Happened to me today.
Win 11 libo 7.6.5.2 and the previous version thad I had (7.6.2 or something like that), French version.

bug is triggered when inputting a letter OR deleting something in that field

Wanted to share a gif screen capture I did but I realize it does not show more than the attachment already there.

Thanks for listening
Comment 7 Commit Notification 2024-04-24 12:58:17 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9d29a2a6aad679129218ab4c5020c92bb3ce9cb3

Resolves tdf#159569 - Conditional Formatting dialog jumps with message string

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2024-04-24 19:48:59 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/32f7ef29615b25e91a73fe33632bb3b7ca506d04

Resolves tdf#159569 - Conditional Formatting dialog jumps with message string

It will be available in 24.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.