Bug 159588 - Query-GUI: LOWER isn't supported in Query-GUI if condition is LIKE …
Summary: Query-GUI: LOWER isn't supported in Query-GUI if condition is LIKE …
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Base (show other bugs)
Version:
(earliest affected)
24.2.0.3 release
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-06 07:13 UTC by Robert Großkopf
Modified: 2025-02-27 19:24 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Test both queries. Execute the queries in design mode. (10.08 KB, application/vnd.oasis.opendocument.database)
2024-02-06 07:13 UTC, Robert Großkopf
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Großkopf 2024-02-06 07:13:28 UTC
Created attachment 192419 [details]
Test both queries. Execute the queries in design mode.

Open the attached database file.
Execute both queries.
Both will look the same.
Open the query gui (Design Mode).
Execute the query in design mode.

qry_Lower won't be executed. 
An error appears:
syntax error, unexpected $end, expecting BETWEEN or IN or SQL_TOKEN_LIKE at /home/buildslave/source/libo-core/dbaccess/source/core/api/SingleSelectQueryComposer.cxx:108

Seems design mode doesn't know anything about LOWER or interprets it wrong way.

Bug appears in LO 24.2.0.3, but also in all earlier versions of LO. Tested here with OpenSUSE 15.4 64bit rpm Linux.
Comment 1 jcsanz 2024-02-06 16:26:43 UTC
It seems the problem is not with LOWER which is executed correctly, but the problem is with the combination of LOWER...LIKE.

To test it I have deleted the condition in LOWER and shown the filed, and the execution of LOWER is correct. When I add the LIKE condition again, then it don't works.

------------
Tested with:
Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: es-ES
Calc: CL threaded
Comment 2 Julien Nabet 2024-02-07 19:18:23 UTC
I gave it a try with https://gerrit.libreoffice.org/c/core/+/163099

Lionel/Juan: I put you in reviewer/cc of the patch, don't hesitate to comment.

I must recognize I don't understand why there were upper_lower/fold parts so perhaps I missed something.
Comment 3 Commit Notification 2024-02-10 11:51:16 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9530664d07f400f4d8dcbe54d0e82d69168844de

tdf#159588: Query-GUI: LOWER isnt supported in Query-GUI if condition is LIKE

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Julien Nabet 2024-02-10 11:52:07 UTC
I pushed it but really not sure so don't hesitate to test.
If there's something wrong happening, I'll revert it.
Comment 5 Julien Nabet 2025-02-27 15:49:12 UTC
Sorry, the patch brings some regression so a revert has been submitted here:
https://gerrit.libreoffice.org/c/core/+/182314
Comment 6 Commit Notification 2025-02-27 15:50:12 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1137a2f025152576790933763daddef7d0c6197f

Revert "tdf#159588: Query-GUI: LOWER isnt supported in Query-GUI if ...

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2025-02-27 18:36:31 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-25-2":

https://git.libreoffice.org/core/commit/fbf433a3af0681fd36835bbc9d8452a6699c2e26

Revert "tdf#159588: Query-GUI: LOWER isnt supported in Query-GUI if ...

It will be available in 25.2.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2025-02-27 19:23:48 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/82b6f749d7ee4b26476d5972a5a4147f4d61da62

Revert "tdf#159588: Query-GUI: LOWER isnt supported in Query-GUI if ...

It will be available in 24.8.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.