Bug 159808 - Date and Time field variants should be named "fixed" instead of "fix"
Summary: Date and Time field variants should be named "fixed" instead of "fix"
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha0+
Hardware: All All
: lowest trivial
Assignee: Not Assigned
URL:
Whiteboard: target:24.8.0
Keywords: difficultyBeginner, easyHack, topicUI
Depends on:
Blocks: UNO-Command-Label
  Show dependency tree / graph
 
Reported: 2024-02-21 01:11 UTC by Stéphane Guillou (stragu)
Modified: 2024-03-05 05:51 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2024-02-21 01:11:25 UTC 
Since 24.2 and 6c073a180b6af61963fcce0da63ba66b97357ccb for bug 139141, we have "fix" labels for such variants of the Date and Time fields (.uno:InsertDateField and .uno:InsertTimeField respectively). This labels is visible in the Insert menu and the Customize dialog.

"fix" is an action, we should really use the adjective "fixed" to match "variable".

Pointer: https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu
Comment 1 Bogaboga Man 2024-02-21 06:20:10 UTC 
(In reply to Stéphane Guillou (stragu) from comment #0)
> Since 24.2 and 6c073a180b6af61963fcce0da63ba66b97357ccb for bug 139141, we
> have "fix" labels for such variants of the Date and Time fields
> (.uno:InsertDateField and .uno:InsertTimeField respectively). This labels is
> visible in the Insert menu and the Customize dialog.
> 
> "fix" is an action, we should really use the adjective "fixed" to match
> "variable".
> 
> Pointer:
> https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/
> openoffice/Office/UI/WriterCommands.xcu

You are absolutely correct. Your concern highlights proper use of the English language.
Comment 2 Xisco Faulí 2024-03-04 11:15:39 UTC 
https://gerrit.libreoffice.org/c/core/+/164351
Comment 3 Commit Notification 2024-03-04 13:20:42 UTC 
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d6f80ddb3f05a3b55239866e6e4d470f6903aaae

tdf#159808: fix -> fixed

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Stéphane Guillou (stragu) 2024-03-05 01:47:52 UTC 
Help fix is in gerrit: https://gerrit.libreoffice.org/c/help/+/164378

We still need:
- dedicated pages for the two variable UNO commands
- link to them in e.g. https://opengrok.libreoffice.org/xref/help/source/text/swriter/02/19040000.xhp or https://opengrok.libreoffice.org/xref/help/source/text/swriter/02/18030000.xhp (this page is duplicated, see bug 160035)
- list them in https://opengrok.libreoffice.org/xref/help/helpers/unocmds.txt, with:
  * .uno:InsertDateFieldVar;swriter/...
  * .uno:InsertTimeFieldVar;swriter/...
Comment 5 Commit Notification 2024-03-05 05:51:40 UTC 
Stéphane Guillou committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/4e69e855e524c31af3592fd9925489ad76f4c842

tdf#159808: update menu entries with fixed vs variable