Bug 159846 - Calc: Disappearing borders on tall merged cells
Summary: Calc: Disappearing borders on tall merged cells
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.2.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:24.8.0 target:24.2.4
Keywords: bibisected, bisected, regression
: 160693 (view as bug list)
Depends on:
Blocks: Cell-Border Calc-Merge-Split
  Show dependency treegraph
 
Reported: 2024-02-22 15:23 UTC by Octavio Alvarez
Modified: 2024-07-11 03:52 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Reproducible on Windows 11, Lib 24.2 (2.21 MB, video/mp4)
2024-02-22 16:33 UTC, Leandro Martín Drudi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Octavio Alvarez 2024-02-22 15:23:11 UTC
Description:
Merged cells that go beyond the current view, have their borders disappear while they are not fully shown in some circumstances. It seems to affect printed documents as well, manifested when the merged cell goes beyond the page.

Steps to Reproduce:
1. New Calc document
2. Merge enough cells from the B column such that they exceed screen height. It's not needed to start at the top. For example, if the spreadsheet is currently showing 30 rows, merge from B20 to A35 or so.
3. Apply full border to the merged cell.
4. Select another cell so the border is clearly on view.
5. Even if the border is not shown, scroll down so the full merged cells gets on view.

Actual Results:
The border is not shown when the merged cell goes beyond view through the bottom side. The border is shown when the merged cell is fully on view or it goes beyond through the top side.

Expected Results:
The border should be always shown.


Reproducible: Always


User Profile Reset: Yes

Additional Info:
This affects printing as well. I tested it horizontally and it happens as well: if the merged cell goes beyond view through the right side, its borders are not shown.

Not seen in 7.6
Seen in 24.2 and 24.8-alpha.
Comment 1 Octavio Alvarez 2024-02-22 15:44:07 UTC
Forgot my version information:

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

OpenCL is not used. Hardware acceleration is disabled. Tried with a new profile.
Comment 2 ady 2024-02-22 16:10:32 UTC
Repro with recent 24.8 alpha on Windows too, with or without Skia.
Comment 3 elmau 2024-02-22 16:14:41 UTC
Repro with:

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: 420(Build:3)
CPU threads: 16; OS: Linux 6.7; UI render: default; VCL: gtk3
Locale: es-MX (en_US.UTF-8); UI: en-US
24.2.0-1
Calc: threaded
Comment 4 ady 2024-02-22 16:31:41 UTC
To be clear, this doesn't happen in 7.6.3.2. > regression.
Comment 5 Leandro Martín Drudi 2024-02-22 16:33:36 UTC
Created attachment 192718 [details]
Reproducible on Windows 11, Lib 24.2
Comment 6 Tex2002ans 2024-02-27 03:39:54 UTC
I believe I bibisected it to this commit:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=e27d4cc31e04be4c47b5085dfa2363ee45457e8a

(Hopefully I did this correct. Only my 2nd bibisect ever.)

I tested in on Windows + followed the video attachment 192718 [details]'s instructions exactly.

Could not reproduce in the 7.6 branch, but could in the 24.2 branch.

- - - - - - -

author	Noel Grandin <noel.grandin@collabora.co.uk>	2023-06-19 12:23:55 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	2023-06-19 18:26:03 +0200
commit e27d4cc31e04be4c47b5085dfa2363ee45457e8a (patch)
tree 75aebab2bd9a0c2d0f152fb545757af0513f5aec
parent 281bdb5a979f0516fe7a9cd35585fd3daf4021b1 (diff)
tdf#150534 reduce the memory consumption of cells when calculating
borders - if there are a lot hidden columns, we end up
allocating a lot of cells. Since most of the cells have the same
settings, use a SfxItemPool to consolidate them.

Change-Id: If2dd77b3eabc5d37eb8804953f8c89ffa04f2400
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153258
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Comment 7 ady 2024-02-27 04:06:26 UTC
(In reply to Tex2002ans from comment #6)
> I believe I bibisected it to this commit:
> 
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=e27d4cc31e04be4c47b5085dfa2363ee45457e8a
> 
> Could not reproduce in the 7.6 branch, but could in the 24.2 branch.

Let's CC' Noel then.
Comment 8 Tex2002ans 2024-03-19 03:26:50 UTC Comment hidden (obsolete)
Comment 9 Commit Notification 2024-05-14 16:47:31 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6f8a73a379d97829080367b21d54f9b5fab781c9

tdf#161019 tdf#159846 spreadsheet border rendering

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2024-05-17 11:35:25 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/ab69de0e0aa0c9e48355c9db36c8aa9b93f235d4

tdf#161019 tdf#159846 spreadsheet border rendering

It will be available in 24.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Aron Budea 2024-07-11 03:52:05 UTC
*** Bug 160693 has been marked as a duplicate of this bug. ***